From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH] HID: logitech-dj: Fix check of logi_dj_recv_query_paired_devices() Date: Mon, 5 Aug 2019 10:55:04 +0200 Message-ID: <7988688e-8020-3d03-63cd-d844c01e5bf6@redhat.com> References: <20190725145719.8344-1-yuehaibing@huawei.com> <20190731105927.GA5092@dell5510> <20190731110629.GB5092@dell5510> <3e9bda5b-68dc-15b9-ca79-2e73567ea0a5@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Jiri Kosina Cc: Petr Vorel , YueHaibing , benjamin.tissoires@redhat.com, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org List-Id: linux-input@vger.kernel.org Hi Jiri, On 05-08-19 10:51, Jiri Kosina wrote: > On Wed, 31 Jul 2019, Hans de Goede wrote: > >>>>> In delayedwork_callback(), logi_dj_recv_query_paired_devices >>>>> may return positive value while success now, so check it >>>>> correctly. >>> >>>>> Fixes: dbcbabf7da92 ("HID: logitech-dj: fix return value of >>>>> Fixes: logi_dj_recv_query_hidpp_devices") >>>>> Signed-off-by: YueHaibing >>>> Reviewed-by: Petr Vorel >>> OK, not only it didn't fix problems with logitech mouse (see below), >>> but removing mouses USB dongle effectively crashes kernel, so this one >>> probably >>> shouldn't be applied :). >>> >>> [ 330.721629] logitech-djreceiver: probe of 0003:046D:C52F.0013 failed with >>> error 7 >>> [ 331.462335] hid 0003:046D:C52F.0013: delayedwork_callback: >>> logi_dj_recv_query_paired_devices error: 7 >> >> Please test my patch titled: "HID: logitech-dj: Really fix return value of >> logi_dj_recv_query_hidpp_devices" >> which should fix this. > > Hans, have I been CCed on that patch? I don't seem to see it in in inbox. I have "Jiri Kosina " in the To: for the patch in the copy in my Inbox (I always Cc myself). Anyways, you can grab it here: https://patchwork.kernel.org/patch/11064087/ It has gathered 2 Tested-by-s and 2 Reviewed-by-s since posting, so assuming you like it too, this is ready for merging. Regards, Hans