From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Daniel Kaehn <kaehndan@gmail.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
jikos@kernel.org, benjamin.tissoires@redhat.com,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
ethan.twardy@plexus.com
Subject: Re: [PATCH 4/4] CP2112 Devicetree Support
Date: Tue, 31 Jan 2023 17:45:44 +0100 [thread overview]
Message-ID: <7a414b9c-4076-19d6-40cb-f80f51969902@linaro.org> (raw)
In-Reply-To: <CAP+ZCCe6J8y=qLMWafXPur1V_0=oQdw2QWqeAZ-C3TroMB4HhA@mail.gmail.com>
On 31/01/2023 02:06, Daniel Kaehn wrote:
> On Sun, Jan 29, 2023 at 5:06 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 28/01/2023 21:26, Danny Kaehn wrote:
>>> +#if defined(CONFIG_OF_GPIO)
>>
>> Don't use #if, but IS_ENABLED(). I think it should work here.
>
> I think I will still need to use an #if / some sort of preprocessor directive,
> since of_node is only a member of the gpio_chip struct if that is enabled
> (and thus causes a compile error if done outside of the preprocessor)...
> Unless I'm misinterpreting your comment?
If of_node in gpio_chip is indeed hidden by #ifdef, then the code is ok.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-31 16:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-28 20:26 [PATCH 0/4] DeviceTree Support for USB-HID Devices and CP2112 Danny Kaehn
2023-01-28 20:26 ` [PATCH 1/4] dt-bindings: hid: Add CP2112 HID USB to SMBus Bridge Danny Kaehn
2023-01-29 11:05 ` Krzysztof Kozlowski
2023-01-29 11:33 ` Krzysztof Kozlowski
2023-01-31 0:25 ` Daniel Kaehn
2023-01-28 20:26 ` [PATCH 2/4] Share USB device devicetree node with child HID device Danny Kaehn
2023-01-29 11:05 ` Krzysztof Kozlowski
2023-01-28 20:26 ` [PATCH 3/4] Fix CP2112 driver not registering GPIO IRQ chip as threaded Danny Kaehn
2023-01-28 20:26 ` [PATCH 4/4] CP2112 Devicetree Support Danny Kaehn
2023-01-29 11:06 ` Krzysztof Kozlowski
2023-01-31 1:06 ` Daniel Kaehn
2023-01-31 16:45 ` Krzysztof Kozlowski [this message]
2023-01-30 16:29 ` [PATCH 0/4] DeviceTree Support for USB-HID Devices and CP2112 Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a414b9c-4076-19d6-40cb-f80f51969902@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=benjamin.tissoires@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=ethan.twardy@plexus.com \
--cc=jikos@kernel.org \
--cc=kaehndan@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).