From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F176C636D3 for ; Tue, 31 Jan 2023 16:45:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231508AbjAaQpv (ORCPT ); Tue, 31 Jan 2023 11:45:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231485AbjAaQpt (ORCPT ); Tue, 31 Jan 2023 11:45:49 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97832564B3 for ; Tue, 31 Jan 2023 08:45:47 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id m7so14795477wru.8 for ; Tue, 31 Jan 2023 08:45:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=N6MGQ9vFPf/PTOMa+Z1CFX94OOnbAZXq2mwlJ2U/izQ=; b=rIJC16gfTs8/WJLZD3b9Yq5SgiLR2O+VykjtBb3ukzqsjOwKzT3SONLqYych3cGLKA LXKil0VgdrQQQD0UWgBcQVgLQhO46RHdgrXCjbn9knu5mVaKNunVOWCtPF8notj/TlOK 0+ON8SkYPM6Xb7m3t+svtW3uZFHOX04j8QXWax/bckKNZbDq5emW7YrDxUawNhyn8gDX bRT1L/N3nAlSHmC2eyM/qxsF3YyTOzvtW1kFuYZhQjFsH4/yStVGlzTLaDAFl6M8d3xp WCdfO+RF/J2dvs/ZMfF6PRTVmtSbC24FvhBAR/kdk/9MpDrylAIf7zZ5cK1z2DMFkS13 I3dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N6MGQ9vFPf/PTOMa+Z1CFX94OOnbAZXq2mwlJ2U/izQ=; b=j6suCoVMuxUTqG4NlGHVEJcfCWpTRBqQaTIEdiPlqAIO9sHIOgcjbqOI7sqaXe43v4 mWexmeLLTV5gM4O7ipFuez/Me2TlOlTomT2iiDLjQnRy9KJaFZc0cdvzqDRuKM/g7+nx KMxoi//7Pq1cK+aLRiW0b48dOQoqxZN0QHf8aYK71f5qQQojVlVAbnyF2f+3pnnFUpJ/ u4gewhfkRqGT7SUJ6UIBoMIoj8dqweQ9PPyH7vwU3KIKKEBscwT8ErFZnbPzQBMSrVok Dto8ynWI8NjFcGsaL1VS2Nnn3KWlxF8OoIS2ljO0UqcVfNdMEKG2VEU8KZkZx29EKRwa Lo4w== X-Gm-Message-State: AO0yUKW66Cj1m+brfLcfYGjI0w4gkFnzfqkHw0v04fyikK82puBFI8NF 6jFYwMEeV1LiQQK3s0R6JooQzgpspefC+by7 X-Google-Smtp-Source: AK7set8HwVxFxeGIJJe7A328sxFXBHw7JRelwm/IIZ1PB2qBlTX4xwpuKXk9gplOppvubNgZXuI6Gw== X-Received: by 2002:a5d:6683:0:b0:2bf:e4d9:2c2b with SMTP id l3-20020a5d6683000000b002bfe4d92c2bmr10295846wru.48.1675183546246; Tue, 31 Jan 2023 08:45:46 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id l15-20020a5d6d8f000000b002bfb37497a8sm16087489wrs.31.2023.01.31.08.45.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 08:45:45 -0800 (PST) Message-ID: <7a414b9c-4076-19d6-40cb-f80f51969902@linaro.org> Date: Tue, 31 Jan 2023 17:45:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 4/4] CP2112 Devicetree Support Content-Language: en-US To: Daniel Kaehn Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, jikos@kernel.org, benjamin.tissoires@redhat.com, devicetree@vger.kernel.org, linux-input@vger.kernel.org, ethan.twardy@plexus.com References: <20230128202622.12676-1-kaehndan@gmail.com> <20230128202622.12676-5-kaehndan@gmail.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 31/01/2023 02:06, Daniel Kaehn wrote: > On Sun, Jan 29, 2023 at 5:06 AM Krzysztof Kozlowski > wrote: >> >> On 28/01/2023 21:26, Danny Kaehn wrote: >>> +#if defined(CONFIG_OF_GPIO) >> >> Don't use #if, but IS_ENABLED(). I think it should work here. > > I think I will still need to use an #if / some sort of preprocessor directive, > since of_node is only a member of the gpio_chip struct if that is enabled > (and thus causes a compile error if done outside of the preprocessor)... > Unless I'm misinterpreting your comment? If of_node in gpio_chip is indeed hidden by #ifdef, then the code is ok. Best regards, Krzysztof