From: "Filipe Laíns" <lains@archlinux.org>
To: "Jérôme de Bretagne" <jerome.debretagne@gmail.com>,
"Jiri Kosina" <jikos@kernel.org>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org
Cc: Jason Gerecke <jason.gerecke@wacom.com>,
Ping Cheng <ping.cheng@wacom.com>
Subject: Re: [PATCH] HID: wacom: Add Dell Latitude 7275 battery quirk
Date: Sat, 04 Sep 2021 23:56:32 +0100 [thread overview]
Message-ID: <7da980efbabf5487016253029375f4e275403933.camel@archlinux.org> (raw)
In-Reply-To: <20210904205840.78242-1-jerome.debretagne@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1358 bytes --]
On Sat, 2021-09-04 at 22:58 +0200, Jérôme de Bretagne wrote:
> The Wacom touchscreen/digitizer in the Dell Latitude 7275
> mistakenly reports having a battery, add a quirk to ignore it.
>
> Signed-off-by: Jérôme de Bretagne <jerome.debretagne@gmail.com>
> Tested-by: Jérôme de Bretagne <jerome.debretagne@gmail.com>
> ---
> drivers/hid/wacom_wac.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c
> index 81ba642adcb7..4d4503cbe308 100644
> --- a/drivers/hid/wacom_wac.c
> +++ b/drivers/hid/wacom_wac.c
> @@ -3574,6 +3574,13 @@ void wacom_setup_device_quirks(struct wacom *wacom)
> __clear_bit(MSC_SERIAL, wacom_wac->pen_input->mscbit);
> __clear_bit(EV_MSC, wacom_wac->pen_input->evbit);
> }
> +
> + /*
> + * The Wacom touchscreen/digitizer in the Dell Latitude 7275
> mistakenly
> + * reports having a battery, let's ignore it.
> + */
> + if (wacom->hdev->product == 0x4804)
We probably want a define for this ID.
> + features->quirks &= ~WACOM_QUIRK_BATTERY;
> }
>
> int wacom_setup_pen_input_capabilities(struct input_dev *input_dev,
Cheers,
Filipe Laíns
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-09-04 23:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 20:58 [PATCH] HID: wacom: Add Dell Latitude 7275 battery quirk Jérôme de Bretagne
[not found] ` <CANRwn3S1qTcDWXrXr0WBoC4RSrB=CjrRom3=GXD8Tby=Y+W=8g@mail.gmail.com>
2021-09-04 22:53 ` Jérôme de Bretagne
2021-09-04 22:56 ` Filipe Laíns [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7da980efbabf5487016253029375f4e275403933.camel@archlinux.org \
--to=lains@archlinux.org \
--cc=benjamin.tissoires@redhat.com \
--cc=jason.gerecke@wacom.com \
--cc=jerome.debretagne@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=ping.cheng@wacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox