Re: [PATCH v3 2/3] Input: ili210x - convert to dev_err_probe()

[Marek Vasut <marek.vasut@mailbox.org>]

On 1/15/26 5:21 PM, Geert Uytterhoeven wrote:

Hello Geert,

>> --- a/drivers/input/touchscreen/ili210x.c
>> +++ b/drivers/input/touchscreen/ili210x.c
>> @@ -942,15 +942,11 @@ static int ili210x_i2c_probe(struct i2c_client *client)
>>          chip = device_get_match_data(dev);
>>          if (!chip && id)
>>                  chip = (const struct ili2xxx_chip *)id->driver_data;
>> -       if (!chip) {
>> -               dev_err(&client->dev, "unknown device model\n");
>> -               return -ENODEV;
>> -       }
>> +       if (!chip)
>> +               return dev_err_probe(&client->dev, -ENODEV, "unknown device model\n");
>>
>> -       if (client->irq <= 0) {
>> -               dev_err(dev, "No IRQ!\n");
>> -               return -EINVAL;
>> -       }
>> +       if (client->irq <= 0)
>> +               dev_err_probe(dev, -EINVAL, "No IRQ!\n");
> 
> Missing return.
Fixed in v4, which I will send once I get some more feedback, thanks.

Note that this return-less code is removed in 3/3 .