linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shaun Jackman" <sjackman@gmail.com>
To: "Alfred E. Heggestad" <aeh@db.org>
Cc: Jiri Kosina <jikos@jikos.cz>, linux-input@atrey.karlin.mff.cuni.cz
Subject: Re: USB: driver for CM109 chipset
Date: Wed, 29 Aug 2007 12:37:12 -0700	[thread overview]
Message-ID: <7f45d9390708291237k168d8e16w2fb60f0dc010d482@mail.gmail.com> (raw)
In-Reply-To: <46D54385.4010704@db.org>

On 8/29/07, Alfred E. Heggestad <aeh@db.org> wrote:
> here is an updated version of the CM109 driver, now supporting both KIP1000
...
> diff -uprN -X linux-2.6.22.5/Documentation/dontdiff linux-2.6.22.5-orig/drivers/hid/usbhid/hid-quirks.c
> linux-2.6.22.5/drivers/hid/usbhid/hid-quirks.c
> --- linux-2.6.22.5-orig/drivers/hid/usbhid/hid-quirks.c 2007-08-29 11:51:07.000000000 +0200
> +++ linux-2.6.22.5/drivers/hid/usbhid/hid-quirks.c      2007-08-27 21:21:01.000000000 +0200
> @@ -259,6 +259,9 @@
>   #define USB_VENDOR_ID_YEALINK         0x6993
>   #define USB_DEVICE_ID_YEALINK_P1K_P4K_B2K     0xb001
>
> +#define USB_VENDOR_ID_CMEDIA           0x0d8c
> +#define USB_DEVICE_ID_CM109            0x000e
> +
>   /*
>    * Alphabetically sorted blacklist by quirk type.
>    */
> @@ -405,6 +408,7 @@ static const struct hid_blacklist {
>         { USB_VENDOR_ID_WISEGROUP, USB_DEVICE_ID_1_PHIDGETSERVO_20, HID_QUIRK_IGNORE },
>         { USB_VENDOR_ID_WISEGROUP, USB_DEVICE_ID_8_8_4_IF_KIT, HID_QUIRK_IGNORE },
>         { USB_VENDOR_ID_YEALINK, USB_DEVICE_ID_YEALINK_P1K_P4K_B2K, HID_QUIRK_IGNORE },
> +       { USB_VENDOR_ID_CMEDIA, USB_DEVICE_ID_CM109, HID_QUIRK_IGNORE },
>
>         { USB_VENDOR_ID_ACECAD, USB_DEVICE_ID_ACECAD_FLAIR, HID_QUIRK_IGNORE },
>         { USB_VENDOR_ID_ACECAD, USB_DEVICE_ID_ACECAD_302, HID_QUIRK_IGNORE },

A minor detail, but the CMEDIA entry should be sorted alphabetically,
as the comment says. See below.

Cheers,
Shaun

diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
index 6b21a21..a435f5b 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -90,6 +90,9 @@
 #define USB_DEVICE_ID_CODEMERCS_IOW_FIRST	0x1500
 #define USB_DEVICE_ID_CODEMERCS_IOW_LAST	0x15ff

+#define USB_VENDOR_ID_CMEDIA		0x0d8c
+#define USB_DEVICE_ID_CMEDIA_CM109	0x000e
+
 #define USB_VENDOR_ID_CYPRESS		0x04b4
 #define USB_DEVICE_ID_CYPRESS_MOUSE	0x0001
 #define USB_DEVICE_ID_CYPRESS_HIDCOM	0x5500
@@ -387,6 +390,7 @@ static const struct hid_blacklist {
 	{ USB_VENDOR_ID_ASUS, USB_DEVICE_ID_ASUS_LCM, HID_QUIRK_IGNORE},
 	{ USB_VENDOR_ID_BERKSHIRE, USB_DEVICE_ID_BERKSHIRE_PCWD, HID_QUIRK_IGNORE },
 	{ USB_VENDOR_ID_CIDC, 0x0103, HID_QUIRK_IGNORE },
+	{ USB_VENDOR_ID_CMEDIA, USB_DEVICE_ID_CMEDIA_CM109, HID_QUIRK_IGNORE },
 	{ USB_VENDOR_ID_CYPRESS, USB_DEVICE_ID_CYPRESS_HIDCOM, HID_QUIRK_IGNORE },
 	{ USB_VENDOR_ID_CYPRESS, USB_DEVICE_ID_CYPRESS_ULTRAMOUSE, HID_QUIRK_IGNORE },
 	{ USB_VENDOR_ID_DELORME, USB_DEVICE_ID_DELORME_EARTHMATE, HID_QUIRK_IGNORE },

  parent reply	other threads:[~2007-08-29 19:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-26  4:28 USB: driver for CM109 chipset Shaun Jackman
2007-08-26 11:53 ` Thomas Reitmayr
2007-08-26 16:43   ` Shaun Jackman
2007-08-26 18:51 ` Alfred E. Heggestad
2007-08-27  5:57   ` Shaun Jackman
2007-08-27  9:46     ` Jiri Kosina
     [not found]       ` <7f45d9390708282238w7174d105i351e81cd19037d14@mail.gmail.com>
2007-08-29  8:31         ` Jiri Kosina
2007-08-29  9:59           ` Alfred E. Heggestad
2007-08-29 10:21             ` Jiri Kosina
2007-08-29 19:37             ` Shaun Jackman [this message]
2007-08-29 23:07               ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f45d9390708291237k168d8e16w2fb60f0dc010d482@mail.gmail.com \
    --to=sjackman@gmail.com \
    --cc=aeh@db.org \
    --cc=jikos@jikos.cz \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).