From: Kevin Hilman <khilman@baylibre.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
jerome Neanne <jneanne@baylibre.com>,
lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
nm@ti.com, kristo@kernel.org, dmitry.torokhov@gmail.com,
krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com,
will@kernel.org, lee@kernel.org, tony@atomide.com,
vigneshr@ti.com, bjorn.andersson@linaro.org, shawnguo@kernel.org,
geert+renesas@glider.be, dmitry.baryshkov@linaro.org,
marcel.ziswiler@toradex.com, vkoul@kernel.org,
biju.das.jz@bp.renesas.com, arnd@arndb.de, jeff@labundy.com
Cc: afd@ti.com, narmstrong@baylibre.com, msp@baylibre.com,
j-keerthy@ti.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v6 6/6] arm64: defconfig: Add tps65219 as modules
Date: Wed, 12 Oct 2022 10:56:00 -0700 [thread overview]
Message-ID: <7hzge1hqof.fsf@baylibre.com> (raw)
In-Reply-To: <fc1e5799-20ea-de37-6693-e2ea0fb87f13@linaro.org>
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:
> On 12/10/2022 04:39, jerome Neanne wrote:
>>> You explained what you did, which is easily visible. You did not explain
>>> why you are doing it.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>> Thanks for pointing me to the detailed guidelines
>> I'm new to upstream and not well aware of all good practices.
>>
>> Would below commit message be more suitable:
>>
>> Add support for the TPS65219 PMIC by enabling MFD, regulator and
>> power-button drivers. All drivers enabled as modules.
>
> This still says only what you did. I still does not explain why.
Jerome, maybe adding a bit of preamble like:
"Development boards from TI include the TPS65219 PMIC. Add support..."
Krzysztof, I'm the first to argue for descriptive/verbose changelogs,
but IMO, this is getting a little bit nit-picky.
The series adds a new driver, DTS and defconfig patches to enable
support the new driver. The "why" for changes to defconfig changes like
this are kind of implied/obvious, and there is lots of precedent for
changelogs of defconfig changes for simple drivers to simply say "enable
X and Y".
If my above suggesion is not enough, please make a suggestion for what
you think would qualify as an appropritate changelong that answers "why"
for a simple driver change.
Kevin
next prev parent reply other threads:[~2022-10-12 17:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 14:05 [PATCH v6 0/6] Add support for TI TPS65219 PMIC Jerome Neanne
2022-10-11 14:05 ` [PATCH v6 1/6] DONOTMERGE: arm64: dts: ti: Add TI TPS65219 PMIC support for AM642 SK board Jerome Neanne
2022-10-11 14:05 ` [PATCH v6 2/6] DONOTMERGE: arm64: dts: ti: Add pinmux and irq mapping for TPS65219 external interrupts Jerome Neanne
2022-10-11 14:05 ` [PATCH v6 3/6] DONOTMERGE: arm64: dts: ti: k3-am642-sk: Enable tps65219 power-button Jerome Neanne
2022-10-11 14:05 ` [PATCH v6 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC Jerome Neanne
2022-10-31 11:00 ` Lee Jones
2022-11-04 12:58 ` jerome Neanne
2022-11-04 13:56 ` Lee Jones
2022-11-04 14:04 ` jerome Neanne
2022-11-05 0:01 ` Nishanth Menon
2022-11-07 21:14 ` Kevin Hilman
2022-11-09 21:59 ` Andrew Davis
2022-11-10 7:12 ` jerome Neanne
2022-11-10 17:00 ` Kevin Hilman
2022-11-10 17:44 ` Andrew Davis
2022-11-10 20:16 ` Kevin Hilman
2022-10-11 14:05 ` [PATCH v6 5/6] Input: Add tps65219 interrupt driven powerbutton Jerome Neanne
2022-10-12 9:48 ` jerome Neanne
2022-10-11 14:05 ` [PATCH v6 6/6] arm64: defconfig: Add tps65219 as modules Jerome Neanne
2022-10-11 14:48 ` Krzysztof Kozlowski
2022-10-12 8:39 ` jerome Neanne
2022-10-12 13:00 ` Krzysztof Kozlowski
2022-10-12 17:56 ` Kevin Hilman [this message]
2022-10-13 12:32 ` Krzysztof Kozlowski
2022-10-13 13:22 ` jerome Neanne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hzge1hqof.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=afd@ti.com \
--cc=arnd@arndb.de \
--cc=biju.das.jz@bp.renesas.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=j-keerthy@ti.com \
--cc=jeff@labundy.com \
--cc=jneanne@baylibre.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=msp@baylibre.com \
--cc=narmstrong@baylibre.com \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).