From mboxrd@z Thu Jan 1 00:00:00 1970 From: Enric Balletbo i Serra Subject: Re: [PATCH v5 06/36] drm/rockchip: Only wait for panel ACK on PSR entry Date: Tue, 13 Mar 2018 01:26:41 +0100 Message-ID: <804ab508-40b8-71fa-c40b-b54f70fcc453@collabora.com> References: <20180309222327.18689-1-enric.balletbo@collabora.com> <20180309222327.18689-7-enric.balletbo@collabora.com> <1909495.WV5cT3kS9W@diego> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1909495.WV5cT3kS9W@diego> Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org To: =?UTF-8?Q?Heiko_St=c3=bcbner?= Cc: architt@codeaurora.org, inki.dae@samsung.com, thierry.reding@gmail.com, hjc@rock-chips.com, seanpaul@chromium.org, airlied@linux.ie, tfiga@chromium.org, dri-devel@lists.freedesktop.org, dianders@chromium.org, a.hajda@samsung.com, ykk@rock-chips.com, kernel@collabora.com, m.szyprowski@samsung.com, linux-samsung-soc@vger.kernel.org, jy0922.shim@samsung.com, rydberg@bitmath.org, krzk@kernel.org, linux-rockchip@lists.infradead.org, kgene@kernel.org, linux-input@vger.kernel.org, orjan.eide@arm.com, wxt@rock-chips.com, jeffy.chen@rock-chips.com, linux-arm-kernel@lists.infradead.org, mark.yao@rock-chips.com, wzz@rock-chips.com, hl@rock-chips.com, jingoohan1@gmail.com, sw0312.kim@samsung.com, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, Laurent.pinchart@ideasonboard.com List-Id: linux-input@vger.kernel.org On 12/03/18 17:58, Heiko Stübner wrote: > Hi, > > the subject is misleading I think, as this is touching only the generic > bridge code and not anything Rockchip-related, so should probably > be "drm/bridge"? > Right, I'll fix this when I need to send another version, I'll wait, for now, a bit more for reviews on the other patches. Thanks Enric > Am Freitag, 9. März 2018, 23:22:57 CET schrieb Enric Balletbo i Serra: >> From: zain wang >> >> We currently wait for the panel to mirror our intended PSR state >> before continuing on both PSR enter and PSR exit. This is really >> only important to do when we're entering PSR, since we want to >> be sure the last frame we pushed is being served from the panel's >> internal fb before shutting down the soc blocks (vop/analogix). >> >> This patch changes the behavior such that we only wait for the >> panel to complete the PSR transition when we're entering PSR, and >> to skip verification when we're exiting. >> >> Cc: Stéphane Marchesin >> Cc: Sonny Rao >> Signed-off-by: zain wang >> Signed-off-by: Sean Paul >> Signed-off-by: Thierry Escande >> Signed-off-by: Enric Balletbo i Serra >> Tested-by: Marek Szyprowski > > change itself looks good, so > Reviewed-by: Heiko Stuebner >