From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F9E8C38145 for ; Thu, 8 Sep 2022 08:03:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230162AbiIHIDa convert rfc822-to-8bit (ORCPT ); Thu, 8 Sep 2022 04:03:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230098AbiIHID3 (ORCPT ); Thu, 8 Sep 2022 04:03:29 -0400 Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [217.70.178.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BD1BCEB0E; Thu, 8 Sep 2022 01:03:27 -0700 (PDT) Received: (Authenticated sender: hadess@hadess.net) by mail.gandi.net (Postfix) with ESMTPSA id DD9CE20000C; Thu, 8 Sep 2022 08:03:24 +0000 (UTC) Message-ID: <8081fcd13d0aeef26adc51018b7f31a8882dc08c.camel@hadess.net> Subject: Re: [v4 1/5] HID: core: Export hid_match_id() From: Bastien Nocera To: Jiri Kosina Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Benjamin Tissoires , "Peter F . Patel-Schneider" , Filipe =?ISO-8859-1?Q?La=EDns?= , Nestor Lopez Casado Date: Thu, 08 Sep 2022 10:03:24 +0200 In-Reply-To: References: <20220830132549.7240-1-hadess@hadess.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Wed, 2022-09-07 at 22:09 +0200, Jiri Kosina wrote: > On Wed, 7 Sep 2022, Bastien Nocera wrote: > > > > Export hid_match_id() so it can be used in device-specific > > > drivers to > > > implement their own matching with open-coding a match function. > > > > > > Signed-off-by: Bastien Nocera > > > --- > > >  drivers/hid/hid-core.c | 1 + > > >  1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > > > index b7f5566e338d..72f8d8835b34 100644 > > > --- a/drivers/hid/hid-core.c > > > +++ b/drivers/hid/hid-core.c > > > @@ -2088,6 +2088,7 @@ const struct hid_device_id > > > *hid_match_id(const > > > struct hid_device *hdev, > > >   > > >         return NULL; > > >  } > > > +EXPORT_SYMBOL_GPL(hid_match_id); > > >   > > >  static const struct hid_device_id hid_hiddev_list[] = { > > >         { HID_USB_DEVICE(USB_VENDOR_ID_MGE, > > > USB_DEVICE_ID_MGE_UPS) }, > > > > If those patches look good to you, would be great to get merged. > > Benjamin doesn't have the bandwidth to test the patches on his own > > test > > hardware right now, but I've been using them daily for a week now. > > Alright, I was waiting for Ack from Benjamin, but based on this, and > due > to the fact that I don't see any issue with it myself, I've now > applied > the series to for-6.1/logitech branch so that it gets as much linux- > next > exposure as possible. Great, thanks! Peter, if there were any other bugs in the hid-logitech-hidpp implementation that needed handling, please file them at bugzilla.kernel.org so they don't get lost.