From: Bastien Nocera <hadess@hadess.net>
To: Jiri Kosina <jikos@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
oe-kbuild-all@lists.linux.dev, linux-input@vger.kernel.org
Subject: Re: [hid:for-6.20/pm_ptr 7/12] drivers/hid/hid-picolcd_core.c:651:33: error: 'picolcd_suspend' undeclared here (not in a function); did you mean 'picolcd_reset'?
Date: Wed, 28 Jan 2026 18:48:21 +0100 [thread overview]
Message-ID: <809dc7359ac03ef94133f31da6984638d25774ef.camel@hadess.net> (raw)
In-Reply-To: <n7o7o70s-3pp0-r590-p65n-2175r761q79p@xreary.bet>
On Wed, 2026-01-28 at 18:46 +0100, Jiri Kosina wrote:
> On Wed, 28 Jan 2026, Bastien Nocera wrote:
>
> > The wrong version of the patch got scheduled in that branch.
> >
> > The branch has v1 of the patch:
> > https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-6.20/pm_ptr&id=318f7b0f1bea13d3aa0506fe6f40399f11c4ae52
> >
> > This is what v2 looks like:
> > https://patchwork.kernel.org/project/linux-input/patch/20260113092546.265734-8-hadess@hadess.net/
> > which should fix the problem.
> >
> > Note that my v2 patchset also dropped
> > "HID: surface: Use pm_ptr_sleep instead of #ifdef CONFIG_PM_SLEEP"
> > which is still in that branch.
>
> Hm, something went wrong with my b4 workflow then, sorry for the
> noise.
>
> I'll take a look and ensure that the correct version gets queued.
No problems.
I was a little bit worried as I spent quite some time making sure to
test for those problems in patchsets that I sent for hid and for the
Bluetooth subsystem.
I'm glad it's something as simple as the wrong patch being used rather
than my testing being lacking.
Cheers
next prev parent reply other threads:[~2026-01-28 17:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 2:04 [hid:for-6.20/pm_ptr 7/12] drivers/hid/hid-picolcd_core.c:651:33: error: 'picolcd_suspend' undeclared here (not in a function); did you mean 'picolcd_reset'? kernel test robot
2026-01-28 17:43 ` Bastien Nocera
2026-01-28 17:46 ` Jiri Kosina
2026-01-28 17:48 ` Bastien Nocera [this message]
2026-01-28 18:17 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=809dc7359ac03ef94133f31da6984638d25774ef.camel@hadess.net \
--to=hadess@hadess.net \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox