[PATCH] HID: hid-logitech-hidpp: Add support for Logitech G923 wheel Xbox Edition

[PATCH] HID: hid-logitech-hidpp: Add support for Logitech G923 wheel Xbox Edition

[Walt Holman]

[-- Attachment #1: Type: text/plain, Size: 589 bytes --]

Hello, 

This patch adds support for the Logitech G923 Xbox edition steering wheel. This uses the hid-logitech-hidpp kernel module and from my testing, force feedback and all buttons work. This requires the usb_modeswitch application to setup the device in PC mode with a magic string that is the same as the Logitech 920 wheel. Originally I had massaged a patch I found for this wheel, however, much of it was unnecessary and I culled it back to just adding the ID's. Let me know if you need anything else or have any questions. Thanks, 

Signed-off-by: Walt Holman walt@holmansrus.com 


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: logitech-g923-hidpp-clean.patch --]
[-- Type: text/x-patch; name=logitech-g923-hidpp-clean.patch, Size: 1282 bytes --]

diff -u2 -r linux-source/drivers/hid/hid-ids.h linux-target/drivers/hid/hid-ids.h
--- linux-source/drivers/hid/hid-ids.h	2022-12-21 10:48:12.000000000 -0600
+++ linux-target/drivers/hid/hid-ids.h	2022-12-22 12:50:16.403880137 -0600
@@ -820,4 +820,5 @@
 #define USB_DEVICE_ID_LOGITECH_G29_WHEEL	0xc24f
 #define USB_DEVICE_ID_LOGITECH_G920_WHEEL	0xc262
+#define USB_DEVICE_ID_LOGITECH_G923_XBOX_WHEEL	0xc26e
 #define USB_DEVICE_ID_LOGITECH_WINGMAN_F3D	0xc283
 #define USB_DEVICE_ID_LOGITECH_FORCE3D_PRO	0xc286
diff -u2 -r linux-source/drivers/hid/hid-logitech-hidpp.c linux-target/drivers/hid/hid-logitech-hidpp.c
--- linux-source/drivers/hid/hid-logitech-hidpp.c	2022-12-21 10:48:12.000000000 -0600
+++ linux-target/drivers/hid/hid-logitech-hidpp.c	2022-12-22 12:53:36.335755199 -0600
@@ -4341,4 +4341,7 @@
 	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G920_WHEEL),
 		.driver_data = HIDPP_QUIRK_CLASS_G920 | HIDPP_QUIRK_FORCE_OUTPUT_REPORTS},
+	{ /* Logitech G923 Wheel (Xbox version) over USB */
+	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G923_XBOX_WHEEL),
+		.driver_data = HIDPP_QUIRK_CLASS_G920 | HIDPP_QUIRK_FORCE_OUTPUT_REPORTS },
 	{ /* Logitech G Pro Gaming Mouse over USB */
 	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) },

Re: [PATCH] HID: hid-logitech-hidpp: Add support for Logitech G923 wheel Xbox Edition

[Bastien Nocera]

Hey Walt,

On Tue, 2023-01-03 at 09:29 -0600, Walt Holman wrote:
> Hello, 
> 
> This patch adds support for the Logitech G923 Xbox edition steering
> wheel. This uses the hid-logitech-hidpp kernel module and from my
> testing, force feedback and all buttons work. This requires the
> usb_modeswitch application to setup the device in PC mode with a
> magic string that is the same as the Logitech 920 wheel. Originally I
> had massaged a patch I found for this wheel, however, much of it was
> unnecessary and I culled it back to just adding the ID's. Let me know
> if you need anything else or have any questions. Thanks, 
> 
> Signed-off-by: Walt Holman walt@holmansrus.com 
> 

You'll want to follow:
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html
to submit this patch. It definitely shouldn't be an attachment :)

Cheers

Re: [PATCH] HID: hid-logitech-hidpp: Add support for Logitech G923 wheel Xbox Edition

[Walt Holman]

----- On Jan 11, 2023, at 4:28 AM, Bastien Nocera hadess@hadess.net wrote:

> Hey Walt,
> 
> On Tue, 2023-01-03 at 09:29 -0600, Walt Holman wrote:
>> Hello,
>> 
>> This patch adds support for the Logitech G923 Xbox edition steering
>> wheel. This uses the hid-logitech-hidpp kernel module and from my
>> testing, force feedback and all buttons work. This requires the
>> usb_modeswitch application to setup the device in PC mode with a
>> magic string that is the same as the Logitech 920 wheel. Originally I
>> had massaged a patch I found for this wheel, however, much of it was
>> unnecessary and I culled it back to just adding the ID's. Let me know
>> if you need anything else or have any questions. Thanks,
>> 
>> Signed-off-by: Walt Holman walt@holmansrus.com
>> 
> 
> You'll want to follow:
> https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html
> to submit this patch. It definitely shouldn't be an attachment :)
> 
> Cheers

I apologize. I'll re-submit it in a new mail. Thanks,

-Walt