linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Jiri Kosina <jikos@kernel.org>, linux-input@vger.kernel.org
Subject: Re: [PATCH v4 4/4] HID: multitouch: Combine all left-button events in a frame
Date: Wed, 22 Nov 2017 15:01:43 +0100	[thread overview]
Message-ID: <81f6ddf6-9af6-7968-ea3d-43b6b4087b32@redhat.com> (raw)
In-Reply-To: <20171122135925.GN403@mail.corp.redhat.com>

Hi,

On 22-11-17 14:59, Benjamin Tissoires wrote:
> On Nov 22 2017 or thereabouts, Hans de Goede wrote:
>> Hi,
>>
>> On 22-11-17 14:37, Jiri Kosina wrote:
>>> On Wed, 22 Nov 2017, Hans de Goede wrote:
>>>
>>>>> Thanks. Hans, last request for you -- HID_DG_SCANTIME handling has in the
>>>>> meantime added for forwarding the MSC_TIMESTAMP (commit 29cc309d8bf1).
>>>>> Could you please respin your patch on top of that (basically just merge
>>>>> your handling with the one added for MSC_TIMESTAMP) and resend? I'll then
>>>>> queue it for 4.16. Thanks,
>>>>
>>>> Ok, v5 with this fixed coming up.
>>>
>>> Thanks a lot Hans.
>>>
>>>> Since this fixes 2 touchpad models not working (not being usable at
>>>> least) it would be nice to get this series into 4.15 rc2/rc3 as a bugfix
>>>> IMHO.
>>>
>>> Hmm, as this is changing common code paths, I'd prefer not to push it
>>> before next merge window really.
>>
>> I understand, although we are still pre-rc1, so if you queue this up
>> for rc2 we won't miss a lot of the testing window, and I don't
>> think a lot of people with hid-mt touchpads are running -next...
>>
>> Benjamin, what is your take on this?
> 
> Well, I think both arguments are valid. I would think the patch series
> is safe, but we never know.
> How about we schedule this for 4.16 and get it merged in Fedora
> 27/rawhide soon, so it gets the testings you want but is still scheduled
> upstream?

You mean add it to the 4.15 kernels in rawhide? That would work for me.

Regards,

Hans

  reply	other threads:[~2017-11-22 14:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-13 16:32 [PATCH v4 1/4] HID: multitouch: Fix alphabetic sorting of mt_devices table Hans de Goede
2017-11-13 16:32 ` [PATCH v4 2/4] HID: multitouch: Properly deal with Win8 PTP reports with 0 touches Hans de Goede
2017-11-13 16:32 ` [PATCH v4 3/4] HID: multitouch: Only look at non touch fields in first packet of a frame Hans de Goede
2017-11-13 16:32 ` [PATCH v4 4/4] HID: multitouch: Combine all left-button events in " Hans de Goede
2017-11-14  8:02   ` Benjamin Tissoires
2017-11-21 12:11     ` Jiri Kosina
2017-11-22 11:55       ` Hans de Goede
2017-11-22 13:37         ` Jiri Kosina
2017-11-22 13:41           ` Hans de Goede
2017-11-22 13:59             ` Benjamin Tissoires
2017-11-22 14:01               ` Hans de Goede [this message]
2017-11-22 14:08                 ` Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81f6ddf6-9af6-7968-ea3d-43b6b4087b32@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).