From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: Pau Oliva Fora <pau@eslack.org>
Cc: dmitry.torokhov@gmail.com, sam@ravnborg.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add support for HTC Shift Touchscreen
Date: Sun, 18 May 2008 12:39:29 +0300 [thread overview]
Message-ID: <84144f020805180239t4c4952e6i7dcaa224a53bebb7@mail.gmail.com> (raw)
In-Reply-To: <482F09FC.9050403@eslack.org>
On Sat, May 17, 2008 at 7:38 PM, Pau Oliva Fora <pau@eslack.org> wrote:
>>> +struct input_dev *htcpen_dev;
>>
>> Why are you not using isa_register_driver() instead?
>
> I have no specifications from the manufacturer, so don't know how to
> properly prove the device, etc.
You can still use isa_register_driver() which is nicer IMHO.
On Sat, May 17, 2008 at 7:38 PM, Pau Oliva Fora <pau@eslack.org> wrote:
>>> + printk(KERN_INFO "htcpen: module inserted\n");
>>> +
>>> + inb_p(HTCPEN_PORT0);
>>
>> So there's no way to probe the existence of this device?
>
> I can add a minimal sanity check if that is a must, but I don't have
> a datasheet and contacting HTC did not help.
Well, you probably want distributions to be able to enable this by
default so any kind probing is helpful, yes.
next prev parent reply other threads:[~2008-05-18 9:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-17 12:44 [PATCH] Add support for HTC Shift Touchscreen Pau Oliva Fora
2008-05-17 13:01 ` Sam Ravnborg
2008-05-17 13:02 ` Pekka Enberg
2008-05-17 16:38 ` Pau Oliva Fora
2008-05-18 9:26 ` Marcin Slusarz
2008-05-18 9:39 ` Pekka Enberg [this message]
2008-05-19 3:16 ` Pau Oliva Fora
2008-05-19 5:22 ` Pekka Enberg
2008-05-19 15:12 ` Pau Oliva Fora
2008-05-19 15:35 ` Dmitry Torokhov
2008-05-19 23:08 ` Pau Oliva Fora
2008-05-20 1:49 ` Dmitry Torokhov
2008-05-20 11:02 ` Pau Oliva Fora
2008-05-20 13:54 ` Dmitry Torokhov
2008-05-20 19:09 ` Pau Oliva Fora
2008-05-22 0:47 ` Pau Oliva Fora
2008-05-20 12:37 ` Andrey Panin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020805180239t4c4952e6i7dcaa224a53bebb7@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pau@eslack.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).