From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26A7E7FD; Tue, 29 Oct 2024 13:19:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730207982; cv=none; b=d8SRU2dm5RJjE7dCvrGhX0EhgNi86PU5XIED77MUvGs6MMO92BnUkZMJ92NhRZJ41XzLdwcdOUIGqoTmQNfzW52sKwTy6Ed+3f7kF3sBhDq/bLJ8CZ0xm0G6Ha9FXfWXUVKh4biyJqeyPgDu7SY/SNPXHYnbU2fADMJikPS4igQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730207982; c=relaxed/simple; bh=yg/o1pe2Ydem/63Sibmmgle3CvzHEGCl6k/yPdISXbk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Dw5H3HHIGkPmvdoLA7UIIe+KCAETGXq3Qm5pnkY1Rd3I7Y+xW4Y/dVack6VOAxe9Z55ecEQZZVRqUxyaAwI4whs8XZQUo0EdamOCUPPVPXSFnNumaHGQWYjKxWsPz+IozrNqlHUHbnqqjNlDWRhA+Ea7KZT03SMzKfUteyOtxO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jupVmOOT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jupVmOOT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADA34C4CECD; Tue, 29 Oct 2024 13:19:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730207980; bh=yg/o1pe2Ydem/63Sibmmgle3CvzHEGCl6k/yPdISXbk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jupVmOOT8viCJlgqgUFEUb27OtVVigrZ2pJhd9iKCvB/10zyWTxrrzIb7njfq6/vf MQllhg/MbOysT8NMUtBOTqR/2Ek9G+MVnJEYWk/kpnr5soxAKqnskqAZGrxT1o39ew HY5urIBcjDWGtW0+mZ9Tkvwu3iJrf+l+kxt5McLseuj5Pc0OpSdOo4YAqB7xU4Cjsk lww0ry/GuIG7t7bp6z7pMeghTQ9KhXKt3usVje54KSXG6sbmK2TLj12eDOyMq5o+kF RNUVGU5Yva+wybnFnxXYd/1wUpugFZhfHVhpddH4UKJnz9pNkkXv6ypdT83PhmBS1h Tph6H33g14mMQ== Message-ID: <844798ab-2910-458e-a9c5-dc69f5c8e368@kernel.org> Date: Tue, 29 Oct 2024 14:19:34 +0100 Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: input: Add Nuvoton MA35D1 keypad To: Ming-Jen Chen Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mjchen@nuvoton.com, peng.fan@nxp.com, sudeep.holla@arm.com, arnd@arndb.de, conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org, dmitry.torokhov@gmail.com References: <20241022063158.5910-1-mjchen0829@gmail.com> <20241022063158.5910-2-mjchen0829@gmail.com> <871e9a4c-7a3c-4a24-8829-a079983033da@gmail.com> <984781ba-9f4c-4179-84d5-4ab8bbe4c3c6@gmail.com> <9b0a508e-d9ae-45ab-882f-5bc1f03e13db@kernel.org> <5d9e89aa-db10-4367-8417-9fcc1a3bb37a@gmail.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <5d9e89aa-db10-4367-8417-9fcc1a3bb37a@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 29/10/2024 03:00, Ming-Jen Chen wrote: >>>>>>> + >>>>>>> + per-scale: >>>>>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>>>>>> + description: Row Scan Cycle Pre-scale Value (1 to 256). >>>>>> Missing constraints >>>>>> >>>>>>> + >>>>>>> + per-scalediv: >>>>>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>>>>>> + description: Per-scale divider (1 to 256). >>>>>> Missing constraints >>>>>> >>>>>> Both properties are unexpected... aren't you duplicating existing >>>>>> properties? >>>>> pre-scale: >>>>> This value configures the IC register for the row scan cycle >>>>> pre-scaling, with valid values ranging from 1 to 256 >>>>> per-scalediv:(I will change pre-scalediv to pre-scale-div) >>>> Please look for matching existing properties first. >>> I will change it to the following content: >>> >>> nuvoton,scan-time: >> Why? What about my request? > > I utilized|grep| to search for relevant properties in the|input/| folder using keywords such as|scan|,|time|,|period|,|freq|, and|interval|. > While I found some similar properties, I did not locate any that completely meet my requirements. > > For example, I found|"scanning_period"|, which is described as "Time between scans. Each step is 1024 us. Valid 1-256." > I would like to confirm if you are suggesting that I use|scanning_period| and explain my specific use case in the description, > for example: Description of these properties did not tell me much about their purpose and underlying hardware, so I don't know which fits here. It looks like you want to configure clock... but then wording confuses me - "per-scale". What is "per"? Isn't it usually "pre"? So in general I don't know what to recommend you because your patch is really unclear. Please also wrap emails according to mailing lists standards. And use proper line separation of sentences. It's really hard to understand your email. > > nuvoton,scanning-period: > type: uint32 > description: | Set the scan time for each key, specified in terms of keypad IP clock > cycles. The valid range is from 1 to 256. minimum: 1 > maximum: 256 Could you please confirm if this approach aligns with your suggestion, > or if you have any other recommended existing properties? Why this would be board dependent? Best regards, Krzysztof