linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] HID: letsketch: add missing MODULE_DESCRIPTION() macro
@ 2024-06-04 14:20 Jeff Johnson
  2024-06-04 14:31 ` Hans de Goede
  2024-06-06  8:55 ` Benjamin Tissoires
  0 siblings, 2 replies; 3+ messages in thread
From: Jeff Johnson @ 2024-06-04 14:20 UTC (permalink / raw)
  To: Hans de Goede, Jiri Kosina, Benjamin Tissoires
  Cc: linux-input, linux-kernel, kernel-janitors, Jeff Johnson

make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-letsketch.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 drivers/hid/hid-letsketch.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hid/hid-letsketch.c b/drivers/hid/hid-letsketch.c
index 97f047f18136..229820fda960 100644
--- a/drivers/hid/hid-letsketch.c
+++ b/drivers/hid/hid-letsketch.c
@@ -319,4 +319,5 @@ static struct hid_driver letsketch_driver = {
 module_hid_driver(letsketch_driver);
 
 MODULE_AUTHOR("Hans de Goede <hdegoede@redhat.com>");
+MODULE_DESCRIPTION("Driver for the LetSketch / VSON WP9620N drawing tablet");
 MODULE_LICENSE("GPL");

---
base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
change-id: 20240604-md-hid-letsketch-53206a0faa79


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] HID: letsketch: add missing MODULE_DESCRIPTION() macro
  2024-06-04 14:20 [PATCH] HID: letsketch: add missing MODULE_DESCRIPTION() macro Jeff Johnson
@ 2024-06-04 14:31 ` Hans de Goede
  2024-06-06  8:55 ` Benjamin Tissoires
  1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2024-06-04 14:31 UTC (permalink / raw)
  To: Jeff Johnson, Jiri Kosina, Benjamin Tissoires
  Cc: linux-input, linux-kernel, kernel-janitors

Hi,

On 6/4/24 4:20 PM, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-letsketch.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> ---
>  drivers/hid/hid-letsketch.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hid/hid-letsketch.c b/drivers/hid/hid-letsketch.c
> index 97f047f18136..229820fda960 100644
> --- a/drivers/hid/hid-letsketch.c
> +++ b/drivers/hid/hid-letsketch.c
> @@ -319,4 +319,5 @@ static struct hid_driver letsketch_driver = {
>  module_hid_driver(letsketch_driver);
>  
>  MODULE_AUTHOR("Hans de Goede <hdegoede@redhat.com>");
> +MODULE_DESCRIPTION("Driver for the LetSketch / VSON WP9620N drawing tablet");
>  MODULE_LICENSE("GPL");
> 
> ---
> base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
> change-id: 20240604-md-hid-letsketch-53206a0faa79
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] HID: letsketch: add missing MODULE_DESCRIPTION() macro
  2024-06-04 14:20 [PATCH] HID: letsketch: add missing MODULE_DESCRIPTION() macro Jeff Johnson
  2024-06-04 14:31 ` Hans de Goede
@ 2024-06-06  8:55 ` Benjamin Tissoires
  1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Tissoires @ 2024-06-06  8:55 UTC (permalink / raw)
  To: Hans de Goede, Jiri Kosina, Jeff Johnson
  Cc: linux-input, linux-kernel, kernel-janitors

On Tue, 04 Jun 2024 07:20:47 -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-letsketch.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> 

Applied to hid/hid.git (for-6.11/module-description), thanks!

[1/1] HID: letsketch: add missing MODULE_DESCRIPTION() macro
      https://git.kernel.org/hid/hid/c/fae5d8433db2

Cheers,
-- 
Benjamin Tissoires <bentiss@kernel.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-06-06  8:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-04 14:20 [PATCH] HID: letsketch: add missing MODULE_DESCRIPTION() macro Jeff Johnson
2024-06-04 14:31 ` Hans de Goede
2024-06-06  8:55 ` Benjamin Tissoires

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).