From: Krzysztof Kozlowski <krzk@kernel.org>
To: utsav.agarwal@analog.com,
"Michael Hennerich" <michael.hennerich@analog.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Arturs Artamonovs <arturs.artamonovs@analog.com>,
Vasileios Bimpikas <vasileios.bimpikas@analog.com>,
Oliver Gaskell <oliver.gaskell@analog.com>
Subject: Re: [PATCH v6 3/3] dt-bindings: input: Update dtbinding for adp5588
Date: Thu, 4 Jul 2024 12:58:30 +0200 [thread overview]
Message-ID: <857b9398-a19b-4f6d-8a73-647f6aa8eeb3@kernel.org> (raw)
In-Reply-To: <20240704-adp5588_gpio_support-v6-3-cb65514d714b@analog.com>
On 04/07/2024 12:45, Utsav Agarwal via B4 Relay wrote:
> +
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/input/input.h>
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + gpio@34 {
> + compatible = "adi,adp5588";
> + reg = <0x34>;
> +
> + #gpio-cells = <2>;
> + gpio-controller;
> + };
Fix your indentation. It's total mess above.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-04 10:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 10:45 [PATCH v6 0/3] adp5588-keys: Support for dedicated gpio operation Utsav Agarwal via B4 Relay
2024-07-04 10:45 ` [PATCH v6 1/3] iInput: adp5588-keys - use guard notation when acquiring mutexes Utsav Agarwal via B4 Relay
2024-07-04 11:14 ` Nuno Sá
2024-07-04 10:45 ` [PATCH v6 2/3] Input: adp5588-keys - add support for pure gpio Utsav Agarwal via B4 Relay
2024-07-04 11:10 ` Nuno Sá
2024-07-04 12:51 ` Agarwal, Utsav
2024-07-04 10:45 ` [PATCH v6 3/3] dt-bindings: input: Update dtbinding for adp5588 Utsav Agarwal via B4 Relay
2024-07-04 10:58 ` Krzysztof Kozlowski [this message]
2024-07-04 12:55 ` Agarwal, Utsav
2024-07-04 11:13 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=857b9398-a19b-4f6d-8a73-647f6aa8eeb3@kernel.org \
--to=krzk@kernel.org \
--cc=arturs.artamonovs@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=oliver.gaskell@analog.com \
--cc=robh@kernel.org \
--cc=utsav.agarwal@analog.com \
--cc=vasileios.bimpikas@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).