From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: [PATCH 1/2] Input-at32psif: Return directly after a failed kzalloc() in psif_probe() Date: Sat, 2 Jul 2016 21:05:32 +0200 Message-ID: <85f42edb-7ce5-cf23-80f5-48440a14cd94@users.sourceforge.net> References: <566ABCD9.1060404@users.sourceforge.net> <4471604f-f401-bed9-39be-1aff2a92edf6@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mout.web.de ([212.227.15.3]:64592 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752422AbcGBTFm (ORCPT ); Sat, 2 Jul 2016 15:05:42 -0400 In-Reply-To: <4471604f-f401-bed9-39be-1aff2a92edf6@users.sourceforge.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov , linux-input@vger.kernel.org Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Markus Elfring Date: Sat, 2 Jul 2016 18:34:43 +0200 Return directly after a memory allocation failed at the beginning. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/serio/at32psif.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/input/serio/at32psif.c b/drivers/input/serio/at32psif.c index 2e4ff5b..fcb769a 100644 --- a/drivers/input/serio/at32psif.c +++ b/drivers/input/serio/at32psif.c @@ -212,8 +212,7 @@ static int __init psif_probe(struct platform_device *pdev) psif = kzalloc(sizeof(struct psif), GFP_KERNEL); if (!psif) { dev_dbg(&pdev->dev, "out of memory\n"); - ret = -ENOMEM; - goto out; + return -ENOMEM; } psif->pdev = pdev; @@ -297,7 +296,6 @@ out_free_io: kfree(io); out_free_psif: kfree(psif); -out: return ret; } -- 2.9.0