From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: James Ogletree <james.ogletree@cirrus.com>, dmitry.torokhov@gmail.com
Cc: Fred Treven <fred.treven@cirrus.com>,
Ben Bright <ben.bright@cirrus.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
Jean Delvare <jdelvare@suse.de>, Arnd Bergmann <arnd@arndb.de>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Eddie James <eajames@linux.ibm.com>, Jacky Bai <ping.bai@nxp.com>,
Markus Schneider-Pargmann <msp@baylibre.com>,
ChiYuan Huang <cy_huang@richtek.com>,
Jeff LaBundy <jeff@labundy.com>,
Randy Dunlap <rdunlap@infradead.org>,
Jerome Neanne <jneanne@baylibre.com>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
patches@cirrus.com, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: input: cirrus,cs40l50: Support for CS40L50
Date: Thu, 10 Aug 2023 08:19:31 +0200 [thread overview]
Message-ID: <86010807-d6e3-745f-ab39-b58f7f64815d@linaro.org> (raw)
In-Reply-To: <20230809191032.820271-2-james.ogletree@cirrus.com>
On 09/08/2023 21:10, James Ogletree wrote:
> Introduce device tree bindings for the initial commit
> of the CS40L50 driver.
>
> + va-supply:
> + description: Regulator for analog voltage
> +
> + vp-supply:
> + description: Regulator for peak voltage
> +
> + vio-supply:
> + description: Regulator for digital IO voltage
> +
> + cirrus,external-boost:
> + description:
> + Bypass the CS40L50 boost converter.
> +
> + The amplifier on CS40L50 can be powered internally through the boost
> + converter, or else can be powered using an external supply. If an
> + external supply is used, the boost converter must be bypassed.
> + type: boolean
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - reset-gpios
I would expect at least some supplies/regulators to be required. This
should match what the datasheet says. The rest looks good.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-10 6:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 19:10 [PATCH v3 0/2] Add support for CS40L50 James Ogletree
2023-08-09 19:10 ` [PATCH v3 1/2] dt-bindings: input: cirrus,cs40l50: Support " James Ogletree
2023-08-10 6:19 ` Krzysztof Kozlowski [this message]
2023-08-09 19:10 ` [PATCH v3 2/2] Input: cs40l50 - Initial support for Cirrus Logic CS40L50 James Ogletree
2023-08-10 6:17 ` Krzysztof Kozlowski
2023-08-15 15:56 ` James Ogletree
2023-08-15 19:23 ` Krzysztof Kozlowski
2023-08-10 10:30 ` Charles Keepax
2023-08-15 22:33 ` James Ogletree
2023-08-16 8:11 ` Charles Keepax
2023-08-11 4:07 ` Jeff LaBundy
2023-08-16 21:02 ` James Ogletree
2023-08-22 12:43 ` Jeff LaBundy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86010807-d6e3-745f-ab39-b58f7f64815d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arnd@arndb.de \
--cc=bartosz.golaszewski@linaro.org \
--cc=ben.bright@cirrus.com \
--cc=conor+dt@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eajames@linux.ibm.com \
--cc=fred.treven@cirrus.com \
--cc=james.ogletree@cirrus.com \
--cc=jdelvare@suse.de \
--cc=jeff@labundy.com \
--cc=jneanne@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msp@baylibre.com \
--cc=patches@cirrus.com \
--cc=ping.bai@nxp.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).