public inbox for linux-input@vger.kernel.org
 help / color / mirror / Atom feed
From: "Derek J. Clark" <derekjohn.clark@gmail.com>
To: Jiri Kosina <jikos@kernel.org>, Mark Pearson <mpearson-lenovo@squebb.ca>
Cc: Benjamin Tissoires <bentiss@kernel.org>,
	"Limonciello, Mario" <mario.limonciello@amd.com>,
	Zhixin Zhang <zhangzx36@lenovo.com>,
	Mia Shao <shaohz1@lenovo.com>,
	"Pierre-Loup A . Griffais" <pgriffais@valvesoftware.com>,
	linux-input@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 02/16] HID: hid-lenovo-go: Add Lenovo Legion Go Series HID Driver
Date: Wed, 21 Jan 2026 05:16:55 -0800	[thread overview]
Message-ID: <8693204A-60AF-48CF-B453-446ABADDA46C@gmail.com> (raw)
In-Reply-To: <24on5sn2-2726-84q2-635q-9245n343qqrp@xreary.bet>

On January 21, 2026 1:08:18 AM PST, Jiri Kosina <jikos@kernel.org> wrote:
>On Mon, 12 Jan 2026, Mark Pearson wrote:
>
>> >>I am now almost finished with reviewing this pile and am planning to queue 
>> >>it in hid.git shortly, but I have a question regarding the MAINTAINERS 
>> >>entry above.
>> >>
>> >>The title claims support for all of Lenovo HID, but there is much more to 
>> >>it than drivers/hid/hid-lenovo-go.c, specifically in hid-lenovo.c.
>> >>
>> >>So either please make the title more specific (or claim the ownership of 
>> >>the whole Lenovo HID landscape indeed, fine by me, but the please reflect 
>> >>that in F: :) ).
>> >>
>> >>Thanks,
>> >>
>> >
>> > Hi Jiri
>> >
>> > Sure, I've debated using LENOVO LEGION GO HID drivers and LENOVO GO HID 
>> > drivers. Do you have a preference? 
>
>Either works, as far as I am concerned.
>
>> > The other drivers are pretty old and I don't have any hardware that 
>> > would use them so I'd prefer to keep them separate (though I'll 
>> > acknowledge that they don't seem to have a MAINTAINERS entry)
>> >
>> I should probably take a better look at the lenovo-hid driver.
>> 
>> The platforms that it's supporting weren't in the Linux program, so it 
>> never crossed my path before - but looking ahead I think we may need to 
>> contribute some changes there (guessing a little, but I'll know in a few 
>> months time).
>> 
>> Jiri - as that driver is targeted for Thinkpads, I'm OK to take some 
>> responsibility for it if that is useful/helpful.
>
>Perfect, could you please then either send that as a followup patch, or 
>even have it included right as part of Derek's series?
>

If Mark is okay with it I'll just add him and that driver to the same entry.

I'll wait a few days to send a v2 in case there's additional input. 

Thanks,
Derek

>Thanks,
>


  reply	other threads:[~2026-01-21 13:16 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-29  3:17 [PATCH v2 00/16] HID: Add Legion Go and Go S Drivers Derek J. Clark
2025-12-29  3:17 ` [PATCH v2 01/16] include: device.h: Add named device attributes Derek J. Clark
2025-12-29  3:17 ` [PATCH v2 02/16] HID: hid-lenovo-go: Add Lenovo Legion Go Series HID Driver Derek J. Clark
2026-01-12 12:12   ` Jiri Kosina
2026-01-12 17:40     ` Derek J. Clark
2026-01-12 18:20       ` Mark Pearson
2026-01-21  9:08         ` Jiri Kosina
2026-01-21 13:16           ` Derek J. Clark [this message]
2026-01-21 16:44             ` Mark Pearson
2025-12-29  3:17 ` [PATCH v2 03/16] HID: hid-lenovo-go: Add Feature Status Attributes Derek J. Clark
2025-12-29  3:17 ` [PATCH v2 04/16] HID: hid-lenovo-go: Add Rumble and Haptic Settings Derek J. Clark
2025-12-29  3:17 ` [PATCH v2 05/16] HID: hid-lenovo-go: Add FPS Mode DPI settings Derek J. Clark
2025-12-29  3:17 ` [PATCH v2 06/16] HID: hid-lenovo-go: Add RGB LED control interface Derek J. Clark
2025-12-29  3:17 ` [PATCH v2 07/16] HID: hid-lenovo-go: Add Calibration Settings Derek J. Clark
2025-12-29  3:17 ` [PATCH v2 08/16] HID: hid-lenovo-go: Add OS Mode Toggle Derek J. Clark
2025-12-29  3:17 ` [PATCH v2 09/16] HID: Include firmware version in the uevent Derek J. Clark
2025-12-29  3:17 ` [PATCH v2 10/16] HID: hid-lenovo-go-s: Add Lenovo Legion Go S Series HID Driver Derek J. Clark
2025-12-29  3:17 ` [PATCH v2 11/16] HID: hid-lenovo-go-s: Add MCU ID Attribute Derek J. Clark
2025-12-29  3:17 ` [PATCH v2 12/16] HID: hid-lenovo-go-s: Add Feature Status Attributes Derek J. Clark
2025-12-29  3:17 ` [PATCH v2 13/16] HID: hid-lenovo-go-s: Add Touchpad Mode Attributes Derek J. Clark
2025-12-29  3:17 ` [PATCH v2 14/16] HID: hid-lenovo-go-s: Add RGB LED control interface Derek J. Clark
2025-12-29  3:17 ` [PATCH v2 15/16] HID: hid-lenovo-go-s: Add IMU and Touchpad RO Attributes Derek J. Clark
2025-12-29  3:17 ` [PATCH v2 16/16] HID: Add documentation for Lenovo Legion Go drivers Derek J. Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8693204A-60AF-48CF-B453-446ABADDA46C@gmail.com \
    --to=derekjohn.clark@gmail.com \
    --cc=bentiss@kernel.org \
    --cc=jikos@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mpearson-lenovo@squebb.ca \
    --cc=pgriffais@valvesoftware.com \
    --cc=shaohz1@lenovo.com \
    --cc=zhangzx36@lenovo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox