From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37CE8C71134 for ; Wed, 23 Aug 2023 18:33:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238173AbjHWSdZ (ORCPT ); Wed, 23 Aug 2023 14:33:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232847AbjHWSdZ (ORCPT ); Wed, 23 Aug 2023 14:33:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75687CC7; Wed, 23 Aug 2023 11:33:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0471161853; Wed, 23 Aug 2023 18:33:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3613DC433C8; Wed, 23 Aug 2023 18:33:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692815602; bh=YMUP09NkDGPcfFSVMGM1j/fJoS+bPlF5trnx5ae/XkI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=e22fW/UqWCEcdNkbx3phPjrKEdVoz1Vj2h/95vNY1Bjeq5ZWKz8HWCFkHYCNNI2dQ pQ28bhBRElPHEffkKElDbm1xLGmHOiNnfoDlSr/4D6BvCTXMrIo2b1l2gtbfr8UY1T zefUFaMubRPUqrcA9jV8pM3PhHB/S07kiVB+pQLrnDggZTm0jJnZ6X3CgVyaQCtpoh QmxZpS53tqSN5Vy6b2vtHntxQd0kJPDgBBW40tEsLsJcmSEd30DtjarQCtg/LtKHQt YzFwgBhY1UJVAeeKD9YOYPr+firBhWbr6UE3MAkEolwZwZIx7JAmG/xpugeEU/jN2U hOeuiVcd2bPlQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qYsfP-007Rb8-L6; Wed, 23 Aug 2023 19:33:19 +0100 Date: Wed, 23 Aug 2023 19:33:19 +0100 Message-ID: <86fs49fw28.wl-maz@kernel.org> From: Marc Zyngier To: Linus Walleij Cc: Bartosz Golaszewski , Andy Shevchenko , Jiri Kosina , Benjamin Tissoires , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH] HID: cp2112: make the irqchip immutable In-Reply-To: References: <20230822152244.214394-1-brgl@bgdev.pl> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: linus.walleij@linaro.org, brgl@bgdev.pl, andriy.shevchenko@linux.intel.com, jikos@kernel.org, benjamin.tissoires@redhat.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, bartosz.golaszewski@linaro.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Wed, 23 Aug 2023 13:14:59 +0100, Linus Walleij wrote: >=20 > On Tue, Aug 22, 2023 at 5:22=E2=80=AFPM Bartosz Golaszewski wrote: >=20 > > From: Bartosz Golaszewski > > > > This make the GPIO irqchip exposed by the CP2112 driver use an immutable > > irq_chip struct thus addressing the following warning on probe: > > > > (cp2112_gpio): not an immutable chip, please consider fixing it! > > > > Signed-off-by: Bartosz Golaszewski >=20 > Thanks for fixing this. FWIW: > Reviewed-by: Linus Walleij >=20 > Marc Z, have you checked how we stand with immutable GPIO > irqchips? We should be able to smoke it out to default behaviour > soon I think. I haven't recently checked, but I'm still in favour of actively make the new behaviour the only one supported. The sooner we break things, the better... M. --=20 Without deviation from the norm, progress is not possible.