* [PATCH] Input: twl4030_keypad - Fix missing IRQF_ONESHOT as only threaded handler
@ 2021-04-16 2:57 zhuguangqing83
2021-04-16 10:38 ` Felipe Balbi
0 siblings, 1 reply; 2+ messages in thread
From: zhuguangqing83 @ 2021-04-16 2:57 UTC (permalink / raw)
To: Dmitry Torokhov, Krzysztof Kozlowski
Cc: linux-input, linux-kernel, Guangqing Zhu
From: Guangqing Zhu <zhuguangqing83@gmail.com>
Coccinelle noticed:
drivers/input/keyboard/twl4030_keypad.c:413:9-34: ERROR: Threaded IRQ with
no primary handler requested without IRQF_ONESHOT
Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com>
---
drivers/input/keyboard/twl4030_keypad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/twl4030_keypad.c b/drivers/input/keyboard/twl4030_keypad.c
index 77e0743a3cf8..05057ebb1ab2 100644
--- a/drivers/input/keyboard/twl4030_keypad.c
+++ b/drivers/input/keyboard/twl4030_keypad.c
@@ -411,7 +411,7 @@ static int twl4030_kp_probe(struct platform_device *pdev)
* NOTE: we assume this host is wired to TWL4040 INT1, not INT2 ...
*/
error = devm_request_threaded_irq(&pdev->dev, kp->irq, NULL, do_kp_irq,
- 0, pdev->name, kp);
+ IRQF_ONESHOT, pdev->name, kp);
if (error) {
dev_info(kp->dbg_dev, "request_irq failed for irq no=%d: %d\n",
kp->irq, error);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: twl4030_keypad - Fix missing IRQF_ONESHOT as only threaded handler
2021-04-16 2:57 [PATCH] Input: twl4030_keypad - Fix missing IRQF_ONESHOT as only threaded handler zhuguangqing83
@ 2021-04-16 10:38 ` Felipe Balbi
0 siblings, 0 replies; 2+ messages in thread
From: Felipe Balbi @ 2021-04-16 10:38 UTC (permalink / raw)
To: zhuguangqing83, Dmitry Torokhov, Krzysztof Kozlowski
Cc: linux-input, linux-kernel, Guangqing Zhu
[-- Attachment #1: Type: text/plain, Size: 367 bytes --]
zhuguangqing83@gmail.com writes:
> From: Guangqing Zhu <zhuguangqing83@gmail.com>
>
> Coccinelle noticed:
> drivers/input/keyboard/twl4030_keypad.c:413:9-34: ERROR: Threaded IRQ with
> no primary handler requested without IRQF_ONESHOT
>
> Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com>
Reviewed-by: Felipe Balbi <balbi@kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-16 10:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-16 2:57 [PATCH] Input: twl4030_keypad - Fix missing IRQF_ONESHOT as only threaded handler zhuguangqing83
2021-04-16 10:38 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).