From: Rahul Rameshbabu <sergeantsagara@protonmail.com>
To: Nils Tonnaett <ntonnatt@ccrma.Stanford.EDU>
Cc: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hid: Add "Hailuck" to the list of non-apple apple keyboards
Date: Mon, 14 Aug 2023 05:11:04 +0000 [thread overview]
Message-ID: <874jl2tdi3.fsf@protonmail.com> (raw)
In-Reply-To: <20230811202932.30413-1-ntonnatt@ccrma.stanford.edu>
On Fri, 11 Aug, 2023 13:29:31 -0700 "Nils Tonnaett" <ntonnatt@ccrma.Stanford.EDU> wrote:
> Powzan keyboards KB750 and KB770 identify as
> "Hailuck Co.,Ltd USB Keyboard". Adding "Hailuck" to the list
> of non-apple apple keyboards fixes function keys for these models.
>
> Signed-off-by: Nils Tonnaett <ntonnatt@ccrma.stanford.edu>
> ---
You will likely want to resubmit this patch using "HID: apple:" in
place of "hid:" in the commit message subject.
https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/log/drivers/hid/hid-apple.c
> drivers/hid/hid-apple.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> index d7b932925730..6664f90cecaf 100644
> --- a/drivers/hid/hid-apple.c
> +++ b/drivers/hid/hid-apple.c
> @@ -343,7 +343,8 @@ static const struct apple_non_apple_keyboard non_apple_keyboards[] = {
> { "SONiX USB DEVICE" },
> { "Keychron" },
> { "AONE" },
> - { "GANSS" }
> + { "GANSS" },
> + { "Hailuck" }
This isn't a must, but maybe it makes sense to comma terminate the last
member in this array specifically if you will be resubmitting this
change as a v2. This way, future keyboards added will only touch one
line in the patch rather than two.
> };
>
> static bool apple_is_non_apple_keyboard(struct hid_device *hdev)
--
Thanks,
Rahul Rameshbabu
next prev parent reply other threads:[~2023-08-14 5:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 20:29 [PATCH] hid: Add "Hailuck" to the list of non-apple apple keyboards Nils Tonnaett
2023-08-14 5:11 ` Rahul Rameshbabu [this message]
2023-08-15 20:19 ` [PATCH v2] HID: apple: Add "Hailuck" to the list of non-apple keyboards Nils Tonnaett
2023-08-16 2:23 ` Rahul Rameshbabu
2023-08-16 13:21 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jl2tdi3.fsf@protonmail.com \
--to=sergeantsagara@protonmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ntonnatt@ccrma.Stanford.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).