From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 159671B3937; Thu, 24 Oct 2024 15:42:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729784538; cv=none; b=u2x6hY5iFPEpzmOBL3Rd1kirNw4hDk3EhHFT0N5Gw6tCUyc0MbvclggUbmt2wk243pnfsmWtpYGvhdYec6gYjfbZZzWouoE/qWMr4/EINFeroqMz4VjbITo2fOx+oDPyFFmJi5XhWTK7E+1t3MeePu4fcnGoO+6SXAqnITr+1yI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729784538; c=relaxed/simple; bh=fyCVM0H3wBChDlsqqMqAVhOen98CNN27wwnpuqoJWHs=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=umg6neifYt6aw9zUMsT6DbmqnlPTW9gQhf7D68Qxb+bAAQ0UNXz4H8GxsqcDtqGbOd3GldsagF+/Lnq1sVISDumaaKiJBfxlsz6vbyMByMZWqREv+nksFhTbF5qvLF6MNM3sPCy4lCf4OjiCwa5TRwo1OCclZ05wEBQkukWeXWo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=nf7+XH/L; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=bUCNy+kH; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=nf7+XH/L; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=bUCNy+kH; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="nf7+XH/L"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="bUCNy+kH"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="nf7+XH/L"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="bUCNy+kH" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2A8A422129; Thu, 24 Oct 2024 15:42:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1729784533; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e/3cTOJeo8U10J73FzqEOoczI8O2ncrtc0XB23zkv5s=; b=nf7+XH/LuqrxkP91/yVelJSCFw67hxyf6AXFWk3zyABwq4t50EjV4OpunUzQwKh4O0X2HJ 4nMIH+IkWiV+OyB9+2lpXXEkxEb6F9xe7EmRT51s93pHP7VGseNAqLpWkAnTMF4e/9a33H jIwPZWttZWt/MbrLD+5eKYCd75VNgto= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1729784533; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e/3cTOJeo8U10J73FzqEOoczI8O2ncrtc0XB23zkv5s=; b=bUCNy+kHeragGzzLpfz4PtWaPc3dFKTrYqlZNmv+RbyR7CQspcjxEUACIPOU4RaAWi7ash i5YJ2tGAyzT1zcBg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="nf7+XH/L"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=bUCNy+kH DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1729784533; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e/3cTOJeo8U10J73FzqEOoczI8O2ncrtc0XB23zkv5s=; b=nf7+XH/LuqrxkP91/yVelJSCFw67hxyf6AXFWk3zyABwq4t50EjV4OpunUzQwKh4O0X2HJ 4nMIH+IkWiV+OyB9+2lpXXEkxEb6F9xe7EmRT51s93pHP7VGseNAqLpWkAnTMF4e/9a33H jIwPZWttZWt/MbrLD+5eKYCd75VNgto= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1729784533; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e/3cTOJeo8U10J73FzqEOoczI8O2ncrtc0XB23zkv5s=; b=bUCNy+kHeragGzzLpfz4PtWaPc3dFKTrYqlZNmv+RbyR7CQspcjxEUACIPOU4RaAWi7ash i5YJ2tGAyzT1zcBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A023D1368E; Thu, 24 Oct 2024 15:42:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id g9J2JdNqGmebSAAAD6G6ig (envelope-from ); Thu, 24 Oct 2024 15:42:11 +0000 Date: Thu, 24 Oct 2024 17:43:12 +0200 Message-ID: <875xphzeun.wl-tiwai@suse.de> From: Takashi Iwai To: Philipp Stanner Cc: Takashi Iwai , Damien Le Moal , Niklas Cassel , Sergey Shtylyov , Basavaraj Natikar , Jiri Kosina , Benjamin Tissoires , Arnd Bergmann , Greg Kroah-Hartman , Alex Dubov , Sudarsana Kalluru , Manish Chopra , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rasesh Mody , GR-Linux-NIC-Dev@marvell.com, Igor Mitsyanko , Sergey Matyukevich , Kalle Valo , Sanjay R Mehta , Shyam Sundar S K , Jon Mason , Dave Jiang , Allen Hubbe , Bjorn Helgaas , Alex Williamson , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jaroslav Kysela , Takashi Iwai , Chen Ni , Mario Limonciello , Ricky Wu , Al Viro , Breno Leitao , Kevin Tian , Thomas Gleixner , Ilpo =?ISO-8859-1?Q?J=E4rvinen?= , Andy Shevchenko , Mostafa Saleh , Jason Gunthorpe , Yi Liu , Christian Brauner , Ankit Agrawal , Eric Auger , Reinette Chatre , Ye Bin , Marek =?ISO-8859-1?Q?Marczykowski-G=F3recki?= , Pierre-Louis Bossart , Peter Ujfalusi , Maarten Lankhorst , Kai Vehmanen , Rui Salvaterra , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ntb@lists.linux.dev, linux-pci@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 02/13] ALSA: hda_intel: Use always-managed version of pcim_intx() In-Reply-To: References: <20241015185124.64726-1-pstanner@redhat.com> <20241015185124.64726-3-pstanner@redhat.com> <87v7xk2ps5.wl-tiwai@suse.de> <6f3db65fe9a5dcd1a7a8d9bd5352ecb248ef57b1.camel@redhat.com> <87ttd2276j.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 2A8A422129 X-Spam-Score: -3.51 X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; ARC_NA(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FREEMAIL_ENVRCPT(0.00)[yahoo.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[suse.de,kernel.org,omp.ru,amd.com,arndb.de,linuxfoundation.org,yahoo.com,marvell.com,davemloft.net,google.com,redhat.com,quantenna.com,gmail.com,kudzu.us,intel.com,suse.com,epam.com,perex.cz,iscas.ac.cn,realtek.com,zeniv.linux.org.uk,debian.org,linutronix.de,linux.intel.com,ziepe.ca,nvidia.com,huawei.com,invisiblethingslab.com,linux.dev,vger.kernel.org,lists.linux.dev,lists.xenproject.org]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_GT_50(0.00)[67]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Flag: NO X-Spam-Level: On Thu, 24 Oct 2024 10:02:59 +0200, Philipp Stanner wrote: > > On Wed, 2024-10-23 at 17:03 +0200, Takashi Iwai wrote: > > On Wed, 23 Oct 2024 15:50:09 +0200, > > Philipp Stanner wrote: > > > > > > On Tue, 2024-10-22 at 16:08 +0200, Takashi Iwai wrote: > > > > On Tue, 15 Oct 2024 20:51:12 +0200, > > > > Philipp Stanner wrote: > > > > > > > > > > pci_intx() is a hybrid function which can sometimes be managed > > > > > through > > > > > devres. To remove this hybrid nature from pci_intx(), it is > > > > > necessary to > > > > > port users to either an always-managed or a never-managed > > > > > version. > > > > > > > > > > hda_intel enables its PCI-Device with pcim_enable_device(). > > > > > Thus, > > > > > it needs > > > > > the always-managed version. > > > > > > > > > > Replace pci_intx() with pcim_intx(). > > > > > > > > > > Signed-off-by: Philipp Stanner > > > > > --- > > > > >  sound/pci/hda/hda_intel.c | 2 +- > > > > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/sound/pci/hda/hda_intel.c > > > > > b/sound/pci/hda/hda_intel.c > > > > > index b4540c5cd2a6..b44ca7b6e54f 100644 > > > > > --- a/sound/pci/hda/hda_intel.c > > > > > +++ b/sound/pci/hda/hda_intel.c > > > > > @@ -786,7 +786,7 @@ static int azx_acquire_irq(struct azx > > > > > *chip, > > > > > int do_disconnect) > > > > >   } > > > > >   bus->irq = chip->pci->irq; > > > > >   chip->card->sync_irq = bus->irq; > > > > > - pci_intx(chip->pci, !chip->msi); > > > > > + pcim_intx(chip->pci, !chip->msi); > > > > >   return 0; > > > > >  } > > > > >   > > > > > > > > Hm, it's OK-ish to do this as it's practically same as what > > > > pci_intx() > > > > currently does.  But, the current code can be a bit inconsistent > > > > about > > > > the original intx value.  pcim_intx() always stores !enable to > > > > res->orig_intx unconditionally, and it means that the orig_intx > > > > value > > > > gets overridden at each time pcim_intx() gets called. > > > > > > Yes. > > > > > > > > > > > Meanwhile, HD-audio driver does release and re-acquire the > > > > interrupt > > > > after disabling MSI when something goes wrong, and pci_intx() > > > > call > > > > above is a part of that procedure.  So, it can rewrite the > > > > res->orig_intx to another value by retry without MSI.  And after > > > > the > > > > driver removal, it'll lead to another state. > > > > > > I'm not sure that I understand this paragraph completely. Still, > > > could > > > a solution for the driver on the long-term just be to use > > > pci_intx()? > > > > pci_intx() misses the restore of the original value, so it's no > > long-term solution, either. > > Sure that is missing – I was basically asking whether the driver could > live without that feature. > > Consider that point obsolete, see below > > > > > What I meant is that pcim_intx() blindly assumes the negative of the > > passed argument as the original state, which isn't always true.  e.g. > > when the driver calls it twice with different values, a wrong value > > may be remembered. > > Ah, I see – thoguh the issue is when it's called several times with the > *same* value, isn't it? > > E.g. > > pcim_intx(pdev, 1); // 0 is remembered as the old value > pcim_intx(pdev, 1); // 0 is falsely remembered as the old value > > Also, it would seem that calling the function for the first time like > that: > > pcim_intx(pdev, 0); // old value: 1 > > is at least incorrect, because INTx should be 0 per default, shouldn't > it? Could then even be a 1st class bug, because INTx would end up being > enabled despite having been disabled all the time. Yeah, and the unexpected restore can happen even with a single call of pcim_intx(), if the driver calls it unnecessarily. > > That said, I thought of something like below. > > At first glance that looks like a good idea to me, thanks for working > this out! > > IMO you can submit that as a patch so we can discuss it separately. Sure, I'm going to submit later. thanks, Takashi