From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: cgel.zte@gmail.com, dmitry.torokhov@gmail.com
Cc: matthias.bgg@gmail.com, lv.ruyi@zte.com.cn,
fengping.yu@mediatek.com, m.felsch@pengutronix.de,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] input: fix variable type
Date: Wed, 09 Mar 2022 08:07:25 +0100 [thread overview]
Message-ID: <875yontxhu.fsf@baylibre.com> (raw)
In-Reply-To: <20220308025054.2077162-1-lv.ruyi@zte.com.cn>
On Tue, Mar 08, 2022 at 02:50, cgel.zte@gmail.com wrote:
> From: Lv Ruyi (CGEL ZTE) <lv.ruyi@zte.com.cn>
>
> The irq is defined unsigned int. If the platform_get_irq return a negative
> value, data type cast may result in error.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi (CGEL ZTE) <lv.ruyi@zte.com.cn>
> ---
> drivers/input/keyboard/mt6779-keypad.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/mt6779-keypad.c b/drivers/input/keyboard/mt6779-keypad.c
> index 5ff23250ed37..0dbbddc7f298 100644
> --- a/drivers/input/keyboard/mt6779-keypad.c
> +++ b/drivers/input/keyboard/mt6779-keypad.c
> @@ -91,7 +91,7 @@ static void mt6779_keypad_clk_disable(void *data)
> static int mt6779_keypad_pdrv_probe(struct platform_device *pdev)
> {
> struct mt6779_keypad *keypad;
> - unsigned int irq;
> + int irq;
> u32 debounce;
> bool wakeup;
> int error;
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> --
> 2.25.1
prev parent reply other threads:[~2022-03-09 7:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 2:50 [PATCH] input: fix variable type cgel.zte
2022-03-09 7:07 ` Mattijs Korpershoek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yontxhu.fsf@baylibre.com \
--to=mkorpershoek@baylibre.com \
--cc=cgel.zte@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=fengping.yu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lv.ruyi@zte.com.cn \
--cc=m.felsch@pengutronix.de \
--cc=matthias.bgg@gmail.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).