From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: Re: [PATCH v3 02/12] ALSA: ac97: add an ac97 bus Date: Wed, 05 Jul 2017 22:21:39 +0200 Message-ID: <877ezmtz1o.fsf@belgarion.home> References: <20170630194408.24978-1-robert.jarzmik@free.fr> <20170630194408.24978-3-robert.jarzmik@free.fr> <87bmp0t2lv.fsf@belgarion.home> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: (Takashi Iwai's message of "Tue, 04 Jul 2017 22:10:28 +0200") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: linux-input@vger.kernel.org, alsa-devel@alsa-project.org, Lars-Peter Clausen , linux-kernel@vger.kernel.org, Dmitry Torokhov , Liam Girdwood , Haojian Zhuang , Mark Brown , linux-arm-kernel@lists.infradead.org, patches@opensource.wolfsonmicro.com, Charles Keepax , Lee Jones , Daniel Mack List-Id: linux-input@vger.kernel.org Takashi Iwai writes: > On Tue, 04 Jul 2017 21:37:48 +0200, > Robert Jarzmik wrote: >> >> Takashi Iwai writes: >> >> > On Fri, 30 Jun 2017 21:43:58 +0200, >> > Robert Jarzmik wrote: >> >> +static struct bus_type ac97_bus_type = { >> >> + .name = "ac97", >> > >> > Name-conflict with the old ac97 bus? >> Yeah, fair point. So what should I choose for this new one ? >> - ac97new >> - ac97bis >> - ac97_2 >> - ac97reborn > > ac97bus > ac97_episode_5 > ac98 > ... > > I have no opinion on it. Ah clone wars one is really tempting :) But let's have ac97bus actually. > You can use subsys_init() for modules, it's no problem. > When it's built for a module, all xxx_init() is handled as equivalent > with module_init(). See linux/module.h. > > It's just the lack of module_exit() in your case. Got it, I'll add it for v4. Cheers. -- Robert