From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Gamari Subject: RE: Why Cypress does not upstream its trackpad driver? Date: Wed, 07 Nov 2012 22:45:31 -0500 Message-ID: <877gpwlpus.fsf@gmail.com> References: <2208882.BvOrfBvj6F@dtor-d630.eng.vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-vc0-f174.google.com ([209.85.220.174]:54510 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753890Ab2KHDpe (ORCPT ); Wed, 7 Nov 2012 22:45:34 -0500 Received: by mail-vc0-f174.google.com with SMTP id fk26so2238301vcb.19 for ; Wed, 07 Nov 2012 19:45:33 -0800 (PST) In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: David Solda , Dmitry Torokhov Cc: Troy Abercrombia , Kamal Mostafa , Ozan =?utf-8?B?w4dhxJ9sYXlhbg==?= , "linux-input@vger.kernel.org" , customercare , "mario_limonciello@dell.com" David Solda writes: > Dmitry, all, > > To clarify my comment. Our protocol utilizes 8 bytes which are needed > in our driver. In order for the Linux system to accept 8 bytes of > data, the Linux psmouse system driver is required to be modified. > Without this modification, the driver that you are referring to will > not work correctly. The psmouse system driver change that would be > required is the item that would be rejected. > > I appreciate your comments and of course, if the driver could be > upstreamed, it would (we already have I2C drivers updstreamed for > Chrome systems), but there is a difference here. > > I will again look into the possibility of what you are requesting, > however, the changes are extremely low if not zero that it will be > accepted. > You are speaking to the people who ultimately decide whether your change will be accepted or not. Currently there is no way anyone could know whether the desired change is acceptable as no patch has been submitted. Send a patch with the (minimal, well-organized) needed changes and the matter can be discussed from there. If the changes are sane and well justified, then there's little reason why they can't be accepted. Cheers, - Ben