From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-input@vger.kernel.org, alsa-devel@alsa-project.org,
Lars-Peter Clausen <lars@metafoo.de>,
linux-kernel@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org,
patches@opensource.wolfsonmicro.com,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
Lee Jones <lee.jones@linaro.org>, Daniel Mack <daniel@zonque.org>
Subject: Re: [PATCH v3 02/12] ALSA: ac97: add an ac97 bus
Date: Tue, 04 Jul 2017 21:37:48 +0200 [thread overview]
Message-ID: <87bmp0t2lv.fsf@belgarion.home> (raw)
In-Reply-To: <s5hpodhc28v.wl-tiwai@suse.de> (Takashi Iwai's message of "Mon, 03 Jul 2017 11:13:04 +0200")
Takashi Iwai <tiwai@suse.de> writes:
> On Fri, 30 Jun 2017 21:43:58 +0200,
> Robert Jarzmik wrote:
>> +static struct bus_type ac97_bus_type = {
>> + .name = "ac97",
>
> Name-conflict with the old ac97 bus?
Yeah, fair point. So what should I choose for this new one ?
- ac97new
- ac97bis
- ac97_2
- ac97reborn
>> +static int __init ac97_bus_init(void)
>> +{
>> + return bus_register(&ac97_bus_type);
>> +}
>> +subsys_initcall(ac97_bus_init);
>> +
>> +MODULE_LICENSE("GPL");
>> +MODULE_AUTHOR("Robert Jarzmik <robert.jarzmik@free.fr>");
>
> No bus_unregister() at exit?
Mmmh, that's because I used subsys_initcall(), which doesn't look good in a
module compilation setup. That will require a module_init(), and I will think
about how to implement it and test it for next iteration.
Cheers.
--
Robert
next prev parent reply other threads:[~2017-07-04 19:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 19:43 [PATCH v3 00/12] AC97 device/driver model revamp Robert Jarzmik
2017-06-30 19:43 ` [PATCH v3 01/12] ALSA: ac97: split out the generic ac97 registers Robert Jarzmik
2017-06-30 19:43 ` [PATCH v3 02/12] ALSA: ac97: add an ac97 bus Robert Jarzmik
2017-07-03 9:13 ` Takashi Iwai
2017-07-04 19:37 ` Robert Jarzmik [this message]
2017-07-04 20:10 ` Takashi Iwai
2017-07-05 20:21 ` Robert Jarzmik
2017-06-30 19:43 ` [PATCH v3 03/12] ASoC: add new ac97 bus support Robert Jarzmik
2017-06-30 19:44 ` [PATCH v3 04/12] ASoC: arm: make pxa2xx-ac97-lib ac97 codec agnostic Robert Jarzmik
2017-06-30 19:44 ` [PATCH v3 05/12] Input: wm97xx: split out touchscreen registering Robert Jarzmik
2017-07-03 8:58 ` Charles Keepax
2017-06-30 19:44 ` [PATCH v3 06/12] mfd: wm97xx-core: core support for wm97xx Codec Robert Jarzmik
2017-07-03 9:08 ` Charles Keepax
2017-07-20 20:30 ` Robert Jarzmik
2017-06-30 19:44 ` [PATCH v3 07/12] Input: wm97xx: add new AC97 bus support Robert Jarzmik
2017-06-30 19:44 ` [PATCH v3 08/12] ASoC: wm9713: add ac97 new " Robert Jarzmik
2017-06-30 19:44 ` [PATCH v3 09/12] ASoC: wm9712: " Robert Jarzmik
2017-06-30 19:44 ` [PATCH v3 10/12] ASoC: wm9705: add private structure Robert Jarzmik
2017-07-03 9:16 ` Charles Keepax
2017-06-30 19:44 ` [PATCH v3 11/12] ASoC: wm9705: add ac97 new bus support Robert Jarzmik
2017-06-30 19:44 ` [PATCH v3 12/12] ASoC: pxa: switch to new ac97 " Robert Jarzmik
2017-07-12 10:55 ` [PATCH v3 00/12] AC97 device/driver model revamp Mark Brown
2017-07-12 13:41 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmp0t2lv.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=daniel@zonque.org \
--cc=dmitry.torokhov@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).