From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1480C00528 for ; Wed, 2 Aug 2023 13:01:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229607AbjHBNBs (ORCPT ); Wed, 2 Aug 2023 09:01:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232720AbjHBNBr (ORCPT ); Wed, 2 Aug 2023 09:01:47 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16FCC268D for ; Wed, 2 Aug 2023 06:01:45 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-3fe110de3b6so6132155e9.1 for ; Wed, 02 Aug 2023 06:01:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1690981303; x=1691586103; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=PxcPQeW9fzPhjHoLIhMXQEyGNsMbVWBtLHyC7kVUcRQ=; b=1cOzbWtGnNr0oq5YpBkDSPGdXvaaNH5jbOiZt4CfrJ8vLq6b5kf2pI/awLh/qtwrDG sA5qYI2g8HGUgxzh6+wiluabf6nUK/HZZ31rXNJI3dMfA51kG2rW7EYMRq3P96GORVUN q7bi/lCnwxX1hXHT6AZwwK+BAo0oR3feS6AscZ7CTpMXou5qWIPqjc4pyr563ZFTPQBK /hFHhBRbCquIAo9+kX2zyGltTPNrkzeKFNVphVxa3Om/H2zc6kycNs0oxMjxu0aeB/jN qn6ZzgT8Tib+WxdWFZ6jD/H+ke9ijzZH6ODW+C6Hm+QpjvykHCi3Z7PkWfe2bSeXkWXi mRjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690981303; x=1691586103; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PxcPQeW9fzPhjHoLIhMXQEyGNsMbVWBtLHyC7kVUcRQ=; b=CCECvTC3Ld00Fei46mY5vKdU9B6HHW3/X8SwWU2b5eWjPBhDNyIl8YFEv2Lcwr/hhA YkvRMydx2iWosuncb09Qw/SCcD/9ty86kCLCus37Dn+TUD3qHukhb31qe2QG0XB4TqxX gADHBF4QS4G5e2732BKXSY3647XH+vTjWv2+Eg5H6AJB8YL1wU5Ef37EIcAEq+mfJAKl f9u1JuD1i7jU+Szg567SproD/lIhJJEiGXw/jcDtgpMcnvUi2BZ4okXJwve57BNg7qjy fOh0m/j+niE+kdJm7Hvm+PdqbEptDYbkeRT/YfAdtsM/jcvYk/TjhiPjQnDWtu1ejXjs gpKw== X-Gm-Message-State: ABy/qLYxzlJAayl3A5UlWgeOVDfYR27p5DwCA4BfXz4lje3F3/Tt9CYf hwEch6TDJ2bTKDlRuABhW2D0jg== X-Google-Smtp-Source: APBJJlFjjfgcyEYCX0PK9ne2jwjGXvD5H3g617zp2BBhW8ltl39euxhlq/1IV8SvE8lviuvJMHIRaQ== X-Received: by 2002:a05:600c:1d9e:b0:3fe:20f1:fb2 with SMTP id p30-20020a05600c1d9e00b003fe20f10fb2mr5198634wms.6.1690981303368; Wed, 02 Aug 2023 06:01:43 -0700 (PDT) Received: from localhost ([2a01:cb19:8704:be00:4f55:bd9d:611a:6c8e]) by smtp.gmail.com with ESMTPSA id p22-20020a7bcc96000000b003fbdd5d0758sm1609096wma.22.2023.08.02.06.01.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Aug 2023 06:01:42 -0700 (PDT) From: Mattijs Korpershoek To: Dmitry Torokhov , linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jeff LaBundy Subject: Re: [PATCH 03/22] Input: iqs269a - use device core to create driver-specific device attributes In-Reply-To: <20230729005133.1095051-3-dmitry.torokhov@gmail.com> References: <20230729005133.1095051-1-dmitry.torokhov@gmail.com> <20230729005133.1095051-3-dmitry.torokhov@gmail.com> Date: Wed, 02 Aug 2023 15:01:42 +0200 Message-ID: <87cz0538eh.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On ven., juil. 28, 2023 at 17:51, Dmitry Torokhov wrote: > Instead of creating driver-specific device attributes with > devm_device_add_group() have device core do this by setting up dev_groups > pointer in the driver structure. > > Signed-off-by: Dmitry Torokhov Reviewed-by: Mattijs Korpershoek > --- > drivers/input/misc/iqs269a.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/input/misc/iqs269a.c b/drivers/input/misc/iqs269a.c > index c0a085639870..3c636c75e8a1 100644 > --- a/drivers/input/misc/iqs269a.c > +++ b/drivers/input/misc/iqs269a.c > @@ -1586,10 +1586,7 @@ static struct attribute *iqs269_attrs[] = { > &dev_attr_ati_trigger.attr, > NULL, > }; > - > -static const struct attribute_group iqs269_attr_group = { > - .attrs = iqs269_attrs, > -}; > +ATTRIBUTE_GROUPS(iqs269); > > static const struct regmap_config iqs269_regmap_config = { > .reg_bits = 8, > @@ -1671,10 +1668,6 @@ static int iqs269_probe(struct i2c_client *client) > return error; > } > > - error = devm_device_add_group(&client->dev, &iqs269_attr_group); > - if (error) > - dev_err(&client->dev, "Failed to add attributes: %d\n", error); > - > return error; > } > > @@ -1743,6 +1736,7 @@ MODULE_DEVICE_TABLE(of, iqs269_of_match); > static struct i2c_driver iqs269_i2c_driver = { > .driver = { > .name = "iqs269a", > + .dev_groups = iqs269_groups, > .of_match_table = iqs269_of_match, > .pm = pm_sleep_ptr(&iqs269_pm), > }, > -- > 2.41.0.487.g6d72f3e995-goog