From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [RFC] [PATCH v3 1/4] OMAP4: Keyboard controller support Date: Tue, 01 Jun 2010 10:45:56 -0700 Message-ID: <87hblmbq97.fsf@deeprootsystems.com> References: <27F9C60D11D683428E133F85D2BB4A53043E537F73@dlee03.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pw0-f46.google.com ([209.85.160.46]:63228 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756735Ab0FARqB (ORCPT ); Tue, 1 Jun 2010 13:46:01 -0400 In-Reply-To: <27F9C60D11D683428E133F85D2BB4A53043E537F73@dlee03.ent.ti.com> (Abraham Arce's message of "Mon\, 31 May 2010 16\:44\:02 -0500") Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: "Arce, Abraham" Cc: "linux-input@vger.kernel.org" , "linux-omap@vger.kernel.org" , "dmitry.torokhov@gmail.com" "Arce, Abraham" writes: > OMAP4 keyboard controller includes: > - built-in scanning algorithm > - debouncing feature > > Driver implementation is based on matrix_keypac.c > > Signed-off-by: Syed Rafiuddin > Signed-off-by: Abraham Arce > Signed-off-by: Dmitry Torokhov > --- > arch/arm/plat-omap/include/plat/omap4-keypad.h | 23 ++ > drivers/input/keyboard/Kconfig | 10 + > drivers/input/keyboard/Makefile | 1 + > drivers/input/keyboard/omap4-keypad.c | 288 ++++++++++++++++++++++++ > 4 files changed, 322 insertions(+), 0 deletions(-) > create mode 100644 arch/arm/plat-omap/include/plat/omap4-keypad.h > create mode 100644 drivers/input/keyboard/omap4-keypad.c > > diff --git a/arch/arm/plat-omap/include/plat/omap4-keypad.h b/arch/arm/plat-omap/include/plat/omap4-keypad.h > new file mode 100644 > index 0000000..7a6ce70 > --- /dev/null > +++ b/arch/arm/plat-omap/include/plat/omap4-keypad.h > @@ -0,0 +1,23 @@ > +#ifndef ARCH_ARM_PLAT_OMAP4_KEYPAD_H > +#define ARCH_ARM_PLAT_OMAP4_KEYPAD_H > + > +#include > + > +struct omap4_keypad_platform_data { > + const struct matrix_keymap_data *keymap_data; > + > + u8 rows; > + u8 cols; > + > + u16 irq; > + void __iomem *base; > + > + int (*device_enable) (struct platform_device *pdev); > + int (*device_shutdown) (struct platform_device *pdev); > + int (*device_idle) (struct platform_device *pdev); > +}; Abraham, Please drop these from this driver. First, they are not used in the driver, and 2nd, new drivers should use the runtime PM API for this as needed. Kevin