From: Javier Martinez Canillas <javierm@redhat.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@google.com>
Cc: linux-input@vger.kernel.org, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH 2/2] Input: tests - modular KUnit tests should not depend on KUNIT=y
Date: Tue, 02 May 2023 13:19:16 +0200 [thread overview]
Message-ID: <87ildbx9or.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <483c4f520e4acc6357ebba3e605977b4c56374df.1683022164.git.geert+renesas@glider.be>
Hello Geert,
I've only been Cc'ed in patch #2.
Geert Uytterhoeven <geert+renesas@glider.be> writes:
> While KUnit tests that cannot be built as a loadable module must depend
> on "KUNIT=y", this is not true for modular tests, where it adds an
> unnecessary limitation.
>
> Fix this by relaxing the dependency to "KUNIT".
>
> Fixes: fdefcbdd6f361841 ("Input: Add KUnit tests for some of the input core helper functions")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2023-05-02 11:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 10:17 [PATCH 0/2] Input: tests - miscellaneous fixes Geert Uytterhoeven
2023-05-02 10:17 ` [PATCH 1/2] Input: tests - fix use-after-free and refcount underflow in input_test_exit() Geert Uytterhoeven
2023-05-02 10:17 ` [PATCH 2/2] Input: tests - modular KUnit tests should not depend on KUNIT=y Geert Uytterhoeven
2023-05-02 11:19 ` Javier Martinez Canillas [this message]
2023-05-02 11:22 ` Geert Uytterhoeven
2023-05-02 11:34 ` Javier Martinez Canillas
2023-05-04 6:29 ` David Gow
2023-05-02 16:09 ` [PATCH 0/2] Input: tests - miscellaneous fixes Geert Uytterhoeven
2023-05-02 16:31 ` Javier Martinez Canillas
2023-05-02 17:05 ` Dmitry Torokhov
2023-05-03 6:53 ` Geert Uytterhoeven
2023-05-03 7:05 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ildbx9or.fsf@minerva.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=brendan.higgins@linux.dev \
--cc=davidgow@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=kunit-dev@googlegroups.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).