From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: Re: [PATCH v2 12/12] ASoC: Fix use-after-free at card unregistration Date: Mon, 19 Jun 2017 13:57:20 +0200 Message-ID: <87injstckf.fsf@belgarion.home> References: <1497857229-12049-1-git-send-email-robert.jarzmik@free.fr> <1497857229-12049-13-git-send-email-robert.jarzmik@free.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: (Takashi Iwai's message of "Mon, 19 Jun 2017 11:25:13 +0200") Sender: stable-owner@vger.kernel.org To: Takashi Iwai Cc: Dmitry Torokhov , Haojian Zhuang , Liam Girdwood , Mark Brown , Lee Jones , Lars-Peter Clausen , Charles Keepax , Jaroslav Kysela , Daniel Mack , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, patches@opensource.wolfsonmicro.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org List-Id: linux-input@vger.kernel.org Takashi Iwai writes: > On Mon, 19 Jun 2017 09:27:09 +0200, > Robert Jarzmik wrote: >> >> From: Takashi Iwai >> >> soc_cleanup_card_resources() call snd_card_free() at the last of its >> procedure. This turned out to lead to a use-after-free. >> PCM runtimes have been already removed via soc_remove_pcm_runtimes(), >> while it's dereferenced later in soc_pcm_free() called via >> snd_card_free(). >> >> The fix is simple: just move the snd_card_free() call to the beginning >> of the whole procedure. This also gives another benefit: it >> guarantees that all operations have been shut down before actually >> releasing the resources, which was racy until now. >> >> Reported-and-tested-by: Robert Jarzmik >> Cc: >> Signed-off-by: Takashi Iwai > > This patch must be superfluous :) Haha :) My serie shifted by one, so the very first of the serie is therefore missing, formerly "ALSA: ac97: split out the generic ac97 registers" in https://patchwork.kernel.org/patch/9398143/, and the shift triggered the inclusion of the last patch of my tree, ie. yours :) Cheers.