From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 1/3] Input: DaVinci Key Scan Driver Date: Tue, 29 Sep 2009 14:24:40 -0700 Message-ID: <87iqf1v3zb.fsf@deeprootsystems.com> References: <1253811202-21407-1-git-send-email-miguel.aguilar@ridgerun.com> <4ABCD1E8.5000200@ridgerun.com> <0554BEF07D437848AF01B9C9B5F0BC5D92C8EBC0@dlee01.ent.ti.com> <4ABCD78B.5050605@ridgerun.com> <20090928170231.GD21455@core.coreip.homeip.net> <0554BEF07D437848AF01B9C9B5F0BC5D92D13959@dlee01.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pz0-f191.google.com ([209.85.222.191]:62951 "EHLO mail-pz0-f191.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752562AbZI2VYi (ORCPT ); Tue, 29 Sep 2009 17:24:38 -0400 Received: by pzk29 with SMTP id 29so3736702pzk.33 for ; Tue, 29 Sep 2009 14:24:42 -0700 (PDT) In-Reply-To: <0554BEF07D437848AF01B9C9B5F0BC5D92D13959@dlee01.ent.ti.com> (Sandeep Paulraj's message of "Mon\, 28 Sep 2009 12\:06\:58 -0500") Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: "Paulraj, Sandeep" Cc: Dmitry Torokhov , Miguel Aguilar , "davinci-linux-open-source@linux.davincidsp.com" , "clark.becker@ridgerun.com" , "linux-input@vger.kernel.org" , "santiago.nunez@ridgerun.com" , "todd.fischer@ridgerun.com" "Paulraj, Sandeep" writes: >> >> On Fri, Sep 25, 2009 at 08:45:31AM -0600, Miguel Aguilar wrote: >> > >> >>>>>> + /* Enable Keyscan module and enable */ >> >>>>>> + davinci_ks_write(davinci_ks, DAVINCI_KEYSCAN_AUTODET | >> >>> DAVINCI_KEYSCAN_KEYEN, >> >>>>>> + DAVINCI_KEYSCAN_KEYCTRL); >> >>>>> We seem to be hardcoded to the 4x4 matrix type here. >> >>>>> Some DM365 boards could use 5x3 matrix. >> >>>>> >> >>>>> Thanks, >> >>>>> Sekhar >> >>>>> >> >>>> [MA] I will add a platform option for matrix type to choose 4x4 or >> 5x3 >> >>> matrix. >> >>>> What do think about this? >> >>>> >> >>> Sounds good. I am not sure if any other piece of code >> >>> needs to change though. >> >> The strobe and interval have to change. Afcourse that change comes >> into the picture only when the mode is changed from 4x4 to 5x3. >> >> I can see that there are options given for this in board specific code. >> >>> Thanks, >> >>> Sekhar >> >> >> >> Thanks, >> >> Sandeep >> >> >> > >> > struct davinci_ks_platform_data { >> > unsigned short *keymap; >> > u32 keymapsize; >> > u32 rep:1; >> > u32 strobe; >> > u32 interval; >> > + u32 matrix_type; >> > }; >> > >> > I will add something like this, so from the board specific code you can >> > define strobe, interval and matrix type. >> >> Make it enum at least. BTW, is it possible to add u8 rows, cols instead >> and be able to handle more matrix variations? > > The IP can handle only 4x4 or 5x3. > Even so, the rows, cols approach is more readable IMO. Kevin