[PATCH 0/3] mt6779-keypad: fix compatibles and add to mt8516

[PATCH 0/3] mt6779-keypad: fix compatibles and add to mt8516

[Val Packett]

The mt8516 patch was previously sent in another series but rejected due
to not using an mt8516 specific compatible - which the other usages
of this driver (mt8183 and mt8365) weren't doing either.

It's only fair to add the SoC-specific compatibles to all of them then :)

Val Packett (3):
  dt-bindings: mediatek,mt6779-keypad: add more compatibles
  arm64: dts: mediatek: add per-SoC compatibles for keypad nodes
  arm64: dts: mediatek: mt8516: add keypad node

 .../bindings/input/mediatek,mt6779-keypad.yaml        |  3 +++
 arch/arm64/boot/dts/mediatek/mt8183.dtsi              |  3 ++-
 arch/arm64/boot/dts/mediatek/mt8365.dtsi              |  3 ++-
 arch/arm64/boot/dts/mediatek/mt8516.dtsi              | 11 +++++++++++
 4 files changed, 18 insertions(+), 2 deletions(-)

-- 
2.47.1

[PATCH 1/3] dt-bindings: mediatek,mt6779-keypad: add more compatibles

[Val Packett]

Add compatibles for SoCs using this device (mt8183, mt8365, mt8516).

Signed-off-by: Val Packett <val@packett.cool>
---
 .../devicetree/bindings/input/mediatek,mt6779-keypad.yaml      | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml
index 47aac8794b689..517a4ac1bea3d 100644
--- a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml
+++ b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml
@@ -26,6 +26,9 @@ properties:
       - items:
           - enum:
               - mediatek,mt6873-keypad
+              - mediatek,mt8183-keypad
+              - mediatek,mt8365-keypad
+              - mediatek,mt8516-keypad
           - const: mediatek,mt6779-keypad
 
   reg:
-- 
2.47.1

Re: [PATCH 1/3] dt-bindings: mediatek,mt6779-keypad: add more compatibles

[Krzysztof Kozlowski]

On Wed, Dec 25, 2024 at 04:26:19PM -0300, Val Packett wrote:
> Add compatibles for SoCs using this device (mt8183, mt8365, mt8516).

This we see from the diff. Say what is less visible, e.g. are they fully
compatible with other variants? Partially?

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

<form letter>
This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions of patchset, under or above your Signed-off-by tag, unless
patch changed significantly (e.g. new properties added to the DT
bindings). Tag is "received", when provided in a message replied to you
on the mailing list. Tools like b4 can help here. However, there's no
need to repost patches *only* to add the tags. The upstream maintainer
will do that for tags received on the version they apply.

https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
</form letter>

Best regards,
Krzysztof

Re: [PATCH 1/3] dt-bindings: mediatek,mt6779-keypad: add more compatibles

[AngeloGioacchino Del Regno]

Il 27/12/24 10:12, Krzysztof Kozlowski ha scritto:
> On Wed, Dec 25, 2024 at 04:26:19PM -0300, Val Packett wrote:
>> Add compatibles for SoCs using this device (mt8183, mt8365, mt8516).
> 
> This we see from the diff. Say what is less visible, e.g. are they fully
> compatible with other variants? Partially?
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 

Yeah saying that they are fully compatible would be good here, but anyway
the change is self-explanatory (just IMO - but I know MTK SoCs so stuff appears
obvious to me from time to time, and might not be obvious for others).

Anyway, input maintainers, please let me know if you want to take this (or the
next version) through the input tree or if I should take it in the MediaTek tree
along with the devicetree changes.

Cheers,
Angelo

> ---
> 
> <form letter>
> This is an automated instruction, just in case, because many review tags
> are being ignored. If you know the process, you can skip it (please do
> not feel offended by me posting it here - no bad intentions intended).
> If you do not know the process, here is a short explanation:
> 
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions of patchset, under or above your Signed-off-by tag, unless
> patch changed significantly (e.g. new properties added to the DT
> bindings). Tag is "received", when provided in a message replied to you
> on the mailing list. Tools like b4 can help here. However, there's no
> need to repost patches *only* to add the tags. The upstream maintainer
> will do that for tags received on the version they apply.
> 
> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
> </form letter>
> 
> Best regards,
> Krzysztof
> 

[PATCH 2/3] arm64: dts: mediatek: add per-SoC compatibles for keypad nodes

[Val Packett]

The mt6779-keypad binding specifies using a compatible for the
actual SoC before the generic MT6779 one.

Fixes: a8013418d35c ("arm64: dts: mediatek: mt8183: add keyboard node")
Fixes: 6ff945376556 ("arm64: dts: mediatek: Initial mt8365-evk support")
Signed-off-by: Val Packett <val@packett.cool>
---
 arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 ++-
 arch/arm64/boot/dts/mediatek/mt8365.dtsi | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index c7008bb8a81da..0aa34e5bbaaa8 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -1024,7 +1024,8 @@ pwrap: pwrap@1000d000 {
 		};
 
 		keyboard: keyboard@10010000 {
-			compatible = "mediatek,mt6779-keypad";
+			compatible = "mediatek,mt8183-keypad",
+				     "mediatek,mt6779-keypad";
 			reg = <0 0x10010000 0 0x1000>;
 			interrupts = <GIC_SPI 186 IRQ_TYPE_EDGE_FALLING>;
 			clocks = <&clk26m>;
diff --git a/arch/arm64/boot/dts/mediatek/mt8365.dtsi b/arch/arm64/boot/dts/mediatek/mt8365.dtsi
index 9c91fe8ea0f96..2bf8c9d02b6ee 100644
--- a/arch/arm64/boot/dts/mediatek/mt8365.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8365.dtsi
@@ -449,7 +449,8 @@ pwrap: pwrap@1000d000 {
 		};
 
 		keypad: keypad@10010000 {
-			compatible = "mediatek,mt6779-keypad";
+			compatible = "mediatek,mt8365-keypad",
+				     "mediatek,mt6779-keypad";
 			reg = <0 0x10010000 0 0x1000>;
 			wakeup-source;
 			interrupts = <GIC_SPI 124 IRQ_TYPE_EDGE_FALLING>;
-- 
2.47.1

Re: [PATCH 2/3] arm64: dts: mediatek: add per-SoC compatibles for keypad nodes

[Krzysztof Kozlowski]

On Wed, Dec 25, 2024 at 04:26:20PM -0300, Val Packett wrote:
> The mt6779-keypad binding specifies using a compatible for the
> actual SoC before the generic MT6779 one.
> 
> Fixes: a8013418d35c ("arm64: dts: mediatek: mt8183: add keyboard node")
> Fixes: 6ff945376556 ("arm64: dts: mediatek: Initial mt8365-evk support")

Not really a fix... or describe the bug.

Best regards,
Krzysztof

[PATCH 3/3] arm64: dts: mediatek: mt8516: add keypad node

[Val Packett]

Add a keypad matrix node for the MT8516/MT8167 SoC.

Signed-off-by: Val Packett <val@packett.cool>
---
 arch/arm64/boot/dts/mediatek/mt8516.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8516.dtsi b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
index e30623ebac0e1..b5e753759465d 100644
--- a/arch/arm64/boot/dts/mediatek/mt8516.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
@@ -220,6 +220,17 @@ timer: timer@10008000 {
 			clock-names = "clk13m", "bus";
 		};
 
+		keypad: keypad@10002000 {
+			compatible = "mediatek,mt8516-keypad",
+				     "mediatek,mt6779-keypad";
+			reg = <0 0x10002000 0 0x1000>;
+			wakeup-source;
+			interrupts = <GIC_SPI 149 IRQ_TYPE_EDGE_FALLING>;
+			clocks = <&clk26m>;
+			clock-names = "kpd";
+			status = "disabled";
+		};
+
 		syscfg_pctl: syscfg-pctl@10005000 {
 			compatible = "syscon";
 			reg = <0 0x10005000 0 0x1000>;
-- 
2.47.1

Re: [PATCH 0/3] mt6779-keypad: fix compatibles and add to mt8516

[AngeloGioacchino Del Regno]

Il 25/12/24 20:26, Val Packett ha scritto:
> The mt8516 patch was previously sent in another series but rejected due
> to not using an mt8516 specific compatible - which the other usages
> of this driver (mt8183 and mt8365) weren't doing either.
> 
> It's only fair to add the SoC-specific compatibles to all of them then :)
> 

Nice!!

Whole series is

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> Val Packett (3):
>    dt-bindings: mediatek,mt6779-keypad: add more compatibles
>    arm64: dts: mediatek: add per-SoC compatibles for keypad nodes
>    arm64: dts: mediatek: mt8516: add keypad node
> 
>   .../bindings/input/mediatek,mt6779-keypad.yaml        |  3 +++
>   arch/arm64/boot/dts/mediatek/mt8183.dtsi              |  3 ++-
>   arch/arm64/boot/dts/mediatek/mt8365.dtsi              |  3 ++-
>   arch/arm64/boot/dts/mediatek/mt8516.dtsi              | 11 +++++++++++
>   4 files changed, 18 insertions(+), 2 deletions(-)
> 

Re: [PATCH 0/3] mt6779-keypad: fix compatibles and add to mt8516

[Mattijs Korpershoek]

Hi Val,

Thank you for the patches.

On mer., déc. 25, 2024 at 16:26, Val Packett <val@packett.cool> wrote:

> The mt8516 patch was previously sent in another series but rejected due
> to not using an mt8516 specific compatible - which the other usages
> of this driver (mt8183 and mt8365) weren't doing either.
>
> It's only fair to add the SoC-specific compatibles to all of them then :)
>
> Val Packett (3):
>   dt-bindings: mediatek,mt6779-keypad: add more compatibles
>   arm64: dts: mediatek: add per-SoC compatibles for keypad nodes
>   arm64: dts: mediatek: mt8516: add keypad node

For the series,

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

>
>  .../bindings/input/mediatek,mt6779-keypad.yaml        |  3 +++
>  arch/arm64/boot/dts/mediatek/mt8183.dtsi              |  3 ++-
>  arch/arm64/boot/dts/mediatek/mt8365.dtsi              |  3 ++-
>  arch/arm64/boot/dts/mediatek/mt8516.dtsi              | 11 +++++++++++
>  4 files changed, 18 insertions(+), 2 deletions(-)
>
> -- 
> 2.47.1

Re: [PATCH 0/3] mt6779-keypad: fix compatibles and add to mt8516

[AngeloGioacchino Del Regno]

On Wed, 25 Dec 2024 16:26:18 -0300, Val Packett wrote:
> The mt8516 patch was previously sent in another series but rejected due
> to not using an mt8516 specific compatible - which the other usages
> of this driver (mt8183 and mt8365) weren't doing either.
> 
> It's only fair to add the SoC-specific compatibles to all of them then :)
> 
> Val Packett (3):
>   dt-bindings: mediatek,mt6779-keypad: add more compatibles
>   arm64: dts: mediatek: add per-SoC compatibles for keypad nodes
>   arm64: dts: mediatek: mt8516: add keypad node
> 
> [...]

Applied to v6.13-next/dts64, thanks!

[1/3] dt-bindings: mediatek,mt6779-keypad: add more compatibles
      commit: 3b19239ad4201123a2bc05af5859f5d75a30a49e
[2/3] arm64: dts: mediatek: add per-SoC compatibles for keypad nodes
      commit: 6139d9e9e397dc9711cf10f8f548a8f9da3b5323
[3/3] arm64: dts: mediatek: mt8516: add keypad node
      commit: 0fb0d360218129f00b76f13e30b86321b64e36f6

Cheers,
Angelo