From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E9DC1632CC; Wed, 13 Nov 2024 16:22:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731514970; cv=none; b=Cr13gJiXTNCl2jPlk2Uy/zZA3hhSHP7lbP3IRO5EKno11GpWLSNEAtt5hzqH++B6XUZFobGODFh5n4kO3PtiGeOkxLBgO6fpJSzmM/gEkSzTDPu+295S6E48zoXRgfNOh+w4J39V7jMtQ7ozH8T3SnKjTeUHZj4I5aXNKZKBfx0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731514970; c=relaxed/simple; bh=ovEF0IzNghLeWdJdF4p31BZ9QZ6SWYBNXusxsXtq72c=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=WM7gi75k2W2T3AHH8EcC5kHIFyYOW1W3xqSG78hZy78baMaQDqF0bDyVc9gA2VjuZU42a7rDRM/lUNXHUwOWHKUSiYUQEEau86ZYbaA4lODSWwem5SEWoEGFCdgkA8yajkc4nmJYeQy1MmGZrwP/UR7LghAkpo6t14Kzm/PbS3g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=2p1i5424; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=2/sBlyjX; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="2p1i5424"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="2/sBlyjX" From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1731514966; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3k8+NXf0XqcxSDVGHG1zcPA7gqnuYQaT+ExzotBYqus=; b=2p1i5424l/Mw2o1go3eZuRlhLFfLu7r8KKASlGO/YPpkQZDBas2eHSNplLNLapYA8yDFgN WCGwOvmnq1Y70YHVSNHcUfBoLXYw7St3krtFkCIvDFofEHsEFJI/tUmpthMj5822ePeIjp ifMBL3OrlRi7yqyJVRpmbh0L7A1joJRZ4KnuDr5zlN46fN8Dou/rizXBUid26Zy+obL29T Cyh07HAwKRIA8BddfyqNCGPoDLMe7kZNM3/4oUePcYUpjpZZSqveBKZGaoen8IK4gL1hrB cLsa/ZQU5GMMglVK24fX2nMABPE7beIyU3V/10IGN6wc7T/52pLz94BPzzuPww== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1731514966; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3k8+NXf0XqcxSDVGHG1zcPA7gqnuYQaT+ExzotBYqus=; b=2/sBlyjXN5KrpH5yo+sPPoE1Vj7RMOF2OIGTxhk0XidvUTXq9URTcJn7IcLDz/JowTbjmq 2LOMU1e9sNdrRBDg== To: Philipp Stanner , Damien Le Moal , Niklas Cassel , Basavaraj Natikar , Jiri Kosina , Benjamin Tissoires , Arnd Bergmann , Greg Kroah-Hartman , Alex Dubov , Sudarsana Kalluru , Manish Chopra , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rasesh Mody , GR-Linux-NIC-Dev@marvell.com, Igor Mitsyanko , Sergey Matyukevich , Kalle Valo , Sanjay R Mehta , Shyam Sundar S K , Jon Mason , Dave Jiang , Allen Hubbe , Bjorn Helgaas , Alex Williamson , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Philipp Stanner , Mario Limonciello , Chen Ni , Ricky Wu , Al Viro , Breno Leitao , Kevin Tian , Mostafa Saleh , Andy Shevchenko , Jason Gunthorpe , Yi Liu , Kunwu Chan , Ankit Agrawal , Christian Brauner , Reinette Chatre , Eric Auger , Ye Bin Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ntb@lists.linux.dev, linux-pci@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 11/11] Remove devres from pci_intx() In-Reply-To: <20241113124158.22863-13-pstanner@redhat.com> References: <20241113124158.22863-2-pstanner@redhat.com> <20241113124158.22863-13-pstanner@redhat.com> Date: Wed, 13 Nov 2024 17:22:45 +0100 Message-ID: <87msi3ksru.ffs@tglx> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, Nov 13 2024 at 13:41, Philipp Stanner wrote: > pci_intx() is a hybrid function which can sometimes be managed through > devres. This hybrid nature is undesirable. > > Since all users of pci_intx() have by now been ported either to > always-managed pcim_intx() or never-managed pci_intx_unmanaged(), the > devres functionality can be removed from pci_intx(). > > Consequently, pci_intx_unmanaged() is now redundant, because pci_intx() > itself is now unmanaged. > > Remove the devres functionality from pci_intx(). Have all users of > pci_intx_unmanaged() call pci_intx(). Remove pci_intx_unmanaged(). > > Signed-off-by: Philipp Stanner > --- > drivers/misc/cardreader/rtsx_pcr.c | 2 +- > drivers/misc/tifm_7xx1.c | 6 +-- > .../net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +- > drivers/net/ethernet/brocade/bna/bnad.c | 2 +- > drivers/ntb/hw/amd/ntb_hw_amd.c | 4 +- > drivers/ntb/hw/intel/ntb_hw_gen1.c | 2 +- > drivers/pci/devres.c | 4 +- > drivers/pci/msi/api.c | 2 +- > drivers/pci/msi/msi.c | 2 +- > drivers/pci/pci.c | 43 +------------------ > drivers/vfio/pci/vfio_pci_core.c | 2 +- > drivers/vfio/pci/vfio_pci_intrs.c | 10 ++--- > drivers/xen/xen-pciback/conf_space_header.c | 2 +- > include/linux/pci.h | 1 - > 14 files changed, 22 insertions(+), 62 deletions(-) Now I'm utterly confused. This undoes the pci_intx_unmanaged() churn which you carefully split into several patches first. So the net change is that: 1) pci_intx() is now always unmanaged 2) a couple of drivers use pcim_intx() now instead of pci_intx() The obvious ordering is: 1) Convert the drivers which need the managed version to use pcim_intx() 2) Remove the managed warning in pci_intx() and clean up the comment 3) Remove __pcim_intx() and invoke pci_intx() in the devres code. No? Thanks, tglx