From: Jaime Velasco Juan <jsagarribay@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, stable@vger.kernel.org,
Sheng-Liang Song <ssl@chromium.org>
Subject: Re: [PATCH] input: atkbd - Fix broken keyboard in another LG laptop
Date: Thu, 11 Sep 2014 17:53:08 +0100 [thread overview]
Message-ID: <87mwa6xfnv.fsf@gmail.com> (raw)
In-Reply-To: <20140910205213.GD38736@core.coreip.homeip.net>
Dmitry Torokhov <dmitry.torokhov@gmail.com> writes:
> Hi Jamie,
>
> On Wed, Sep 10, 2014 at 07:06:14PM +0100, Jaime Velasco Juan wrote:
>> This model has the same quirk as others, see 3d725caa9dcc "Input:
>> atkbd - fix keyboard not working on some LG laptops"
>>
>
> How about the patch below instead?
>
It works for me just the same, thanks.
Regards
> --
> Dmitry
>
> Input: atkbd - do not try 'deactivate' keyboard on any LG laptops
>
> From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> We are getting more and more reports about LG laptops not having
> functioning keyboard if we try to deactivate keyboard during probe.
> Given that having keyboard deactivated is merely "nice to have"
> instead of a hard requirement for probing, let's disable it on all
> LG boxes instead of trying to hunt down particular models.
>
> This change is prompted by patches trying to add "LG Electronics"/"ROCKY"
> and "LG Electronics"/"LW60-F27B" to the DMI list.
>
> https://bugzilla.kernel.org/show_bug.cgi?id=77051
>
> Cc: stable@vger.kernel.org
> Reported-by: Jaime Velasco Juan <jsagarribay@gmail.com>
> Reported-by: Georgios Tsalikis <georgios@tsalikis.net>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/input/keyboard/atkbd.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
> index 2dd1d0d..6f5d795 100644
> --- a/drivers/input/keyboard/atkbd.c
> +++ b/drivers/input/keyboard/atkbd.c
> @@ -1791,14 +1791,6 @@ static const struct dmi_system_id atkbd_dmi_quirk_table[] __initconst = {
> {
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "LG Electronics"),
> - DMI_MATCH(DMI_PRODUCT_NAME, "LW25-B7HV"),
> - },
> - .callback = atkbd_deactivate_fixup,
> - },
> - {
> - .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "LG Electronics"),
> - DMI_MATCH(DMI_PRODUCT_NAME, "P1-J273B"),
> },
> .callback = atkbd_deactivate_fixup,
> },
next prev parent reply other threads:[~2014-09-11 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 18:06 [PATCH] input: atkbd - Fix broken keyboard in another LG laptop Jaime Velasco Juan
2014-09-10 20:52 ` Dmitry Torokhov
2014-09-11 16:53 ` Jaime Velasco Juan [this message]
2014-09-11 17:03 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwa6xfnv.fsf@gmail.com \
--to=jsagarribay@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=ssl@chromium.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).