* [PATCH 11/32] hid/picolcd_fb: Set FBINFO_VIRTFB flag [not found] <20231115102954.7102-1-tzimmermann@suse.de> @ 2023-11-15 10:19 ` Thomas Zimmermann 2023-11-16 10:27 ` Javier Martinez Canillas 2023-11-21 8:42 ` Jiri Kosina 0 siblings, 2 replies; 5+ messages in thread From: Thomas Zimmermann @ 2023-11-15 10:19 UTC (permalink / raw) To: deller, javierm Cc: linux-fbdev, dri-devel, Thomas Zimmermann, Bruno Prémont, Jiri Kosina, Benjamin Tissoires, linux-input The picolcd_fb driver operates on system memory. Mark the framebuffer accordingly. Helpers operating on the framebuffer memory will test for the presence of this flag. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Cc: "Bruno Prémont" <bonbons@linux-vserver.org> Cc: Jiri Kosina <jikos@kernel.org> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> Cc: linux-input@vger.kernel.org --- drivers/hid/hid-picolcd_fb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c index a4dccdcda26fc..d7dddd99d325e 100644 --- a/drivers/hid/hid-picolcd_fb.c +++ b/drivers/hid/hid-picolcd_fb.c @@ -505,6 +505,7 @@ int picolcd_init_framebuffer(struct picolcd_data *data) dev_err(dev, "can't get a free page for framebuffer\n"); goto err_nomem; } + info->flags |= FBINFO_VIRTFB; info->screen_buffer = fbdata->bitmap; info->fix.smem_start = (unsigned long)fbdata->bitmap; memset(fbdata->vbitmap, 0xff, PICOLCDFB_SIZE); -- 2.42.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 11/32] hid/picolcd_fb: Set FBINFO_VIRTFB flag 2023-11-15 10:19 ` [PATCH 11/32] hid/picolcd_fb: Set FBINFO_VIRTFB flag Thomas Zimmermann @ 2023-11-16 10:27 ` Javier Martinez Canillas 2023-11-17 8:51 ` Bruno Prémont 2023-11-21 8:42 ` Jiri Kosina 1 sibling, 1 reply; 5+ messages in thread From: Javier Martinez Canillas @ 2023-11-16 10:27 UTC (permalink / raw) To: Thomas Zimmermann, deller Cc: linux-fbdev, dri-devel, Thomas Zimmermann, Bruno Prémont, Jiri Kosina, Benjamin Tissoires, linux-input Thomas Zimmermann <tzimmermann@suse.de> writes: > The picolcd_fb driver operates on system memory. Mark the framebuffer > accordingly. Helpers operating on the framebuffer memory will test > for the presence of this flag. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Cc: "Bruno Prémont" <bonbons@linux-vserver.org> > Cc: Jiri Kosina <jikos@kernel.org> > Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> > Cc: linux-input@vger.kernel.org > --- > drivers/hid/hid-picolcd_fb.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> -- Best regards, Javier Martinez Canillas Core Platforms Red Hat ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 11/32] hid/picolcd_fb: Set FBINFO_VIRTFB flag 2023-11-16 10:27 ` Javier Martinez Canillas @ 2023-11-17 8:51 ` Bruno Prémont 0 siblings, 0 replies; 5+ messages in thread From: Bruno Prémont @ 2023-11-17 8:51 UTC (permalink / raw) To: Javier Martinez Canillas Cc: Thomas Zimmermann, deller, linux-fbdev, dri-devel, Bruno Prémont, Jiri Kosina, Benjamin Tissoires, linux-input On Thu, 16 Nov 2023 11:27:55 +0100 Javier Martinez Canillas wrote: > Thomas Zimmermann <tzimmermann@suse.de> writes: > > > The picolcd_fb driver operates on system memory. Mark the framebuffer > > accordingly. Helpers operating on the framebuffer memory will test > > for the presence of this flag. > > > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > > Cc: "Bruno Prémont" <bonbons@linux-vserver.org> > > Cc: Jiri Kosina <jikos@kernel.org> > > Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> > > Cc: linux-input@vger.kernel.org > > --- > > drivers/hid/hid-picolcd_fb.c | 1 + > > 1 file changed, 1 insertion(+) > > > > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Acked-by: Bruno Prémont <bonbons@linux-vserver.org> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 11/32] hid/picolcd_fb: Set FBINFO_VIRTFB flag 2023-11-15 10:19 ` [PATCH 11/32] hid/picolcd_fb: Set FBINFO_VIRTFB flag Thomas Zimmermann 2023-11-16 10:27 ` Javier Martinez Canillas @ 2023-11-21 8:42 ` Jiri Kosina 2023-11-21 8:56 ` Thomas Zimmermann 1 sibling, 1 reply; 5+ messages in thread From: Jiri Kosina @ 2023-11-21 8:42 UTC (permalink / raw) To: Thomas Zimmermann Cc: deller, javierm, linux-fbdev, dri-devel, Bruno Prémont, Benjamin Tissoires, linux-input On Wed, 15 Nov 2023, Thomas Zimmermann wrote: > The picolcd_fb driver operates on system memory. Mark the framebuffer > accordingly. Helpers operating on the framebuffer memory will test > for the presence of this flag. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Cc: "Bruno Prémont" <bonbons@linux-vserver.org> > Cc: Jiri Kosina <jikos@kernel.org> > Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> > Cc: linux-input@vger.kernel.org Acked-by: Jiri Kosina <jkosina@suse.cz> I guess this will go in as one series together, right? -- Jiri Kosina SUSE Labs ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 11/32] hid/picolcd_fb: Set FBINFO_VIRTFB flag 2023-11-21 8:42 ` Jiri Kosina @ 2023-11-21 8:56 ` Thomas Zimmermann 0 siblings, 0 replies; 5+ messages in thread From: Thomas Zimmermann @ 2023-11-21 8:56 UTC (permalink / raw) To: Jiri Kosina Cc: deller, javierm, linux-fbdev, dri-devel, Bruno Prémont, Benjamin Tissoires, linux-input [-- Attachment #1.1: Type: text/plain, Size: 954 bytes --] Hi Am 21.11.23 um 09:42 schrieb Jiri Kosina: > On Wed, 15 Nov 2023, Thomas Zimmermann wrote: > >> The picolcd_fb driver operates on system memory. Mark the framebuffer >> accordingly. Helpers operating on the framebuffer memory will test >> for the presence of this flag. >> >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> >> Cc: "Bruno Prémont" <bonbons@linux-vserver.org> >> Cc: Jiri Kosina <jikos@kernel.org> >> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> >> Cc: linux-input@vger.kernel.org > > Acked-by: Jiri Kosina <jkosina@suse.cz> > > I guess this will go in as one series together, right? Yes. I intend to move all this through the DRM trees. Best regards Thomas > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg) [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 840 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-11-21 8:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20231115102954.7102-1-tzimmermann@suse.de>
2023-11-15 10:19 ` [PATCH 11/32] hid/picolcd_fb: Set FBINFO_VIRTFB flag Thomas Zimmermann
2023-11-16 10:27 ` Javier Martinez Canillas
2023-11-17 8:51 ` Bruno Prémont
2023-11-21 8:42 ` Jiri Kosina
2023-11-21 8:56 ` Thomas Zimmermann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).