From: Rahul Rameshbabu <sergeantsagara@protonmail.com>
To: Su Hui <suhui@nfschina.com>
Cc: ping.cheng@wacom.com, jason.gerecke@wacom.com, jikos@kernel.org,
benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] HID: wacom_sys: add error code check in wacom_feature_mapping
Date: Mon, 06 Nov 2023 06:16:59 +0000 [thread overview]
Message-ID: <87pm0nz9rc.fsf@protonmail.com> (raw)
In-Reply-To: <20231106060815.104971-1-suhui@nfschina.com>
On Mon, 06 Nov, 2023 14:08:16 +0800 "Su Hui" <suhui@nfschina.com> wrote:
> hid_report_raw_event() can return error code like '-ENOMEM' if
> failed, so check 'ret' to make sure all things work fine.
>
> Signed-off-by: Su Hui <suhui@nfschina.com>
> ---
> v2:
> - report the returned error (Rahul Rameshbabu) and __func__.
Thanks for the patch. Like the addition of using __func__.
Reviewed-by: Rahul Rameshbabu <sergeantsagara@protonmail.com>
prev parent reply other threads:[~2023-11-06 6:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 6:08 [PATCH v2] HID: wacom_sys: add error code check in wacom_feature_mapping Su Hui
2023-11-06 6:16 ` Rahul Rameshbabu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm0nz9rc.fsf@protonmail.com \
--to=sergeantsagara@protonmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jason.gerecke@wacom.com \
--cc=jikos@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ping.cheng@wacom.com \
--cc=suhui@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).