* [PATCH v2] HID: wacom_sys: add error code check in wacom_feature_mapping
@ 2023-11-06 6:08 Su Hui
2023-11-06 6:16 ` Rahul Rameshbabu
0 siblings, 1 reply; 2+ messages in thread
From: Su Hui @ 2023-11-06 6:08 UTC (permalink / raw)
To: sergeantsagara, ping.cheng, jason.gerecke, jikos,
benjamin.tissoires
Cc: Su Hui, linux-input, linux-kernel, kernel-janitors
hid_report_raw_event() can return error code like '-ENOMEM' if
failed, so check 'ret' to make sure all things work fine.
Signed-off-by: Su Hui <suhui@nfschina.com>
---
v2:
- report the returned error (Rahul Rameshbabu) and __func__.
drivers/hid/wacom_sys.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
index 3f704b8072e8..899579c6db9d 100644
--- a/drivers/hid/wacom_sys.c
+++ b/drivers/hid/wacom_sys.c
@@ -320,6 +320,9 @@ static void wacom_feature_mapping(struct hid_device *hdev,
if (ret == n && features->type == HID_GENERIC) {
ret = hid_report_raw_event(hdev,
HID_FEATURE_REPORT, data, n, 0);
+ if (ret)
+ hid_warn(hdev, "%s: failed to report feature: %pe\n",
+ __func__, ERR_PTR(ret));
} else if (ret == 2 && features->type != HID_GENERIC) {
features->touch_max = data[1];
} else {
@@ -381,6 +384,9 @@ static void wacom_feature_mapping(struct hid_device *hdev,
if (ret == n) {
ret = hid_report_raw_event(hdev, HID_FEATURE_REPORT,
data, n, 0);
+ if (ret)
+ hid_warn(hdev, "%s: failed to report feature: %pe\n",
+ __func__, ERR_PTR(ret));
} else {
hid_warn(hdev, "%s: could not retrieve sensor offsets\n",
__func__);
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] HID: wacom_sys: add error code check in wacom_feature_mapping
2023-11-06 6:08 [PATCH v2] HID: wacom_sys: add error code check in wacom_feature_mapping Su Hui
@ 2023-11-06 6:16 ` Rahul Rameshbabu
0 siblings, 0 replies; 2+ messages in thread
From: Rahul Rameshbabu @ 2023-11-06 6:16 UTC (permalink / raw)
To: Su Hui
Cc: ping.cheng, jason.gerecke, jikos, benjamin.tissoires, linux-input,
linux-kernel, kernel-janitors
On Mon, 06 Nov, 2023 14:08:16 +0800 "Su Hui" <suhui@nfschina.com> wrote:
> hid_report_raw_event() can return error code like '-ENOMEM' if
> failed, so check 'ret' to make sure all things work fine.
>
> Signed-off-by: Su Hui <suhui@nfschina.com>
> ---
> v2:
> - report the returned error (Rahul Rameshbabu) and __func__.
Thanks for the patch. Like the addition of using __func__.
Reviewed-by: Rahul Rameshbabu <sergeantsagara@protonmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-06 6:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-06 6:08 [PATCH v2] HID: wacom_sys: add error code check in wacom_feature_mapping Su Hui
2023-11-06 6:16 ` Rahul Rameshbabu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).