From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-244108.protonmail.ch (mail-244108.protonmail.ch [109.224.244.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F5CD221D8B for ; Tue, 29 Apr 2025 15:37:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745941070; cv=none; b=WYnSWFYp+158qpoGZLCGBOaHww4yRxnSz//46p7Dsd2q7+moHcaIhMS+63HBc1WaBobm4SwkTn32aVQHeFy7jP1meH9z/8uXDWMhjeQowK2rkUDadiqvzbk+3ZIptbRyA7WyG1JXHLI5bYALjJDEhmnARhdpC2FVjcZSxtwOD0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745941070; c=relaxed/simple; bh=7HjtdAatTMxO2fIKw9ilY3O1msot9+K4zOaYeTD0L+8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=NerloCIINWGTn2sOSs8UiKVdLY7dOfgj8EFpgv72f0RUn+rrd3gQKezGpk21hVlXqOTUwnzWvZTN5GfX0U1tanTx8T6dXlgc/pLv2kDG2B7gvE2Ki3SsW2afe9r6d6igFrQkG5ZfcUBgGCTZjDTYeyylUKdfke5YkchmuRPn0aU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=geanix.com; spf=pass smtp.mailfrom=geanix.com; dkim=pass (2048-bit key) header.d=geanix.com header.i=@geanix.com header.b=nx0ym0oN; arc=none smtp.client-ip=109.224.244.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=geanix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=geanix.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=geanix.com header.i=@geanix.com header.b="nx0ym0oN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=geanix.com; s=protonmail; t=1745941063; x=1746200263; bh=3roM25TOO3IQr63WcJp/bVj3et2BBAqHoVYsNwHrYPQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:From:To: Cc:Date:Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector: List-Unsubscribe:List-Unsubscribe-Post; b=nx0ym0oN7ObSD7gTXP1+lE5B8wg/MG/t7eq41CNw5jHEUT3lDRB7riVJrM/BTZsCq o++k7uXWsngUbcU41HIY8UGVICl3EvPFIu8g99+foWEcAJKoQEsJvAab0cB6/ji521 i3akn0xWjNyIbwFDFdOlq/HVmuI90YgzaWX2TFYQgV6br/FlQv10/PG3Uc1BwjML4r KX/MaceA8uX9W0YKZt6Xts7hXbAXOQjAbipb12kQPQLDkasFSVI6u5uKoC2p56gV+r NgpSbfxRv2z8JFQxq0HhWLXsSrIHbKTVwasOQOvpGTi0Dlx/XgaOaGdfxRQ6LA0p/X yzCc9Sijbue/w== X-Pm-Submission-Id: 4Zn4FW2fkCz44t From: Esben Haabendal To: "Conor Dooley" Cc: "Dmitry Torokhov" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Hans de Goede" , , , Subject: Re: [PATCH v2 1/2] dt-bindings: input: touchscreen: goodix: Add no-reset-pull-up property In-Reply-To: <20250429-effects-subscript-58eb41737816@spud> (Conor Dooley's message of "Tue, 29 Apr 2025 16:31:51 +0100") References: <20250429-goodix-no-reset-pull-up-v2-0-0687a4ad5a04@geanix.com> <20250429-goodix-no-reset-pull-up-v2-1-0687a4ad5a04@geanix.com> <20250429-effects-subscript-58eb41737816@spud> Date: Tue, 29 Apr 2025 17:37:34 +0200 Message-ID: <87selrt1vl.fsf@geanix.com> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain "Conor Dooley" writes: > On Tue, Apr 29, 2025 at 11:56:11AM +0200, Esben Haabendal wrote: >> This should be added for boards where there is no pull-up on the reset pin, >> as the driver will otherwise switch the reset signal to high-impedance to >> save power, which obviously not safe without pull-up. >> >> Signed-off-by: Esben Haabendal >> --- >> Documentation/devicetree/bindings/input/touchscreen/goodix.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml >> index eb4992f708b70fef93bd4b59b9565123f7c6ad5d..21ac13046b6e021eeb403d854aabc945801dd29f 100644 >> --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml >> +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml >> @@ -45,6 +45,10 @@ properties: >> reset-gpios: >> maxItems: 1 >> >> + goodix,no-reset-pull-up: >> + type: boolean >> + description: There is no pull-up on reset pin > > I have to wonder, why are these system using the reset property if the > reset is not usable? Shouldn't the property be omitted? The reset are fully functional. It just have to be controlled in push-pull mode. Because of the lack of external pull-up, configuring the reset gpio as input (to save power) puts the reset pin in an unknown state. /Esben