From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Fabien Parent <fparent@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/4] arm64: dts: mt6358: add mt6358-keys node
Date: Tue, 08 Feb 2022 16:38:50 +0100 [thread overview]
Message-ID: <87v8xps705.fsf@baylibre.com> (raw)
In-Reply-To: <20220121140323.4080640-5-mkorpershoek@baylibre.com>
Hi Matthias,
On ven., janv. 21, 2022 at 15:03, Mattijs Korpershoek <mkorpershoek@baylibre.com> wrote:
> This enables the power,home keys on MediaTek boards with a mt6358 pmic.
>
> Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Since the driver change has been merged [1], can we queue up the DT change?
Or should I resubmit this separately?
Thanks
[1] https://lore.kernel.org/all/YgIE%2F806gDmRJYCn@google.com/
> ---
> arch/arm64/boot/dts/mediatek/mt6358.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt6358.dtsi b/arch/arm64/boot/dts/mediatek/mt6358.dtsi
> index 95145076b7e6..98f3b0e0c9f6 100644
> --- a/arch/arm64/boot/dts/mediatek/mt6358.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt6358.dtsi
> @@ -2,6 +2,7 @@
> /*
> * Copyright (c) 2020 MediaTek Inc.
> */
> +#include <dt-bindings/input/input.h>
>
> &pwrap {
> pmic: mt6358 {
> @@ -357,5 +358,16 @@ mt6358_vsim2_reg: ldo_vsim2 {
> mt6358rtc: mt6358rtc {
> compatible = "mediatek,mt6358-rtc";
> };
> +
> + mt6358keys: mt6358keys {
> + compatible = "mediatek,mt6358-keys";
> + power {
> + linux,keycodes = <KEY_POWER>;
> + wakeup-source;
> + };
> + home {
> + linux,keycodes = <KEY_HOME>;
> + };
> + };
> };
> };
> --
> 2.32.0
next prev parent reply other threads:[~2022-02-08 15:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 14:03 [PATCH v4 0/4] input: MT6358 PMIC button support Mattijs Korpershoek
2022-01-21 14:03 ` [PATCH v4 1/4] Input: mtk-pmic-keys - use get_irq_byname() instead of index Mattijs Korpershoek
2022-02-08 5:51 ` Dmitry Torokhov
2022-01-21 14:03 ` [PATCH v4 2/4] dt-bindings: input: mtk-pmic-keys: add MT6358 binding definition Mattijs Korpershoek
2022-02-08 5:51 ` Dmitry Torokhov
2022-01-21 14:03 ` [PATCH v4 3/4] Input: mtk-pmic-keys - add support for MT6358 Mattijs Korpershoek
2022-02-08 5:51 ` Dmitry Torokhov
2022-01-21 14:03 ` [PATCH v4 4/4] arm64: dts: mt6358: add mt6358-keys node Mattijs Korpershoek
2022-02-08 15:38 ` Mattijs Korpershoek [this message]
2022-03-01 7:44 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8xps705.fsf@baylibre.com \
--to=mkorpershoek@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fparent@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).