Re: [PATCH] Input: mt6779-keypad - fix signedness bug in probe

[Mattijs Korpershoek <mkorpershoek@baylibre.com>]

Hi Dan,

On lun., mars 14, 2022 at 17:00, Dan Carpenter <dan.carpenter@oracle.com> wrote:

> The "irq" variable needs to be signed for the error handling to work.
>
> Fixes: f28af984e771 ("Input: mt6779-keypad - add MediaTek keypad driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thank you for the patch.

This was already reported and fixed at [1]

[1] https://lore.kernel.org/linux-input/20220308025054.2077162-1-lv.ruyi@zte.com.cn/

> ---
>  drivers/input/keyboard/mt6779-keypad.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/mt6779-keypad.c b/drivers/input/keyboard/mt6779-keypad.c
> index 5ff23250ed37..abd7e346203d 100644
> --- a/drivers/input/keyboard/mt6779-keypad.c
> +++ b/drivers/input/keyboard/mt6779-keypad.c
> @@ -91,10 +91,10 @@ static void mt6779_keypad_clk_disable(void *data)
>  static int mt6779_keypad_pdrv_probe(struct platform_device *pdev)
>  {
>  	struct mt6779_keypad *keypad;
> -	unsigned int irq;
>  	u32 debounce;
>  	bool wakeup;
>  	int error;
> +	int irq;
>  
>  	keypad = devm_kzalloc(&pdev->dev, sizeof(*keypad), GFP_KERNEL);
>  	if (!keypad)
> -- 
> 2.20.1