From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: Re: [PATCH v3] ARM: pxa: magician: Add support for ADS7846 touchscreen Date: Fri, 17 Mar 2017 08:14:43 +0100 Message-ID: <87wpbofk7w.fsf@belgarion.home> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: (Petr Cvek's message of "Mon, 13 Mar 2017 09:05:49 +0100") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Petr Cvek , philipp.zabel@gmail.com Cc: linux-arm-kernel@lists.infradead.org, haojian.zhuang@gmail.com, daniel@zonque.org, linux-input@vger.kernel.org List-Id: linux-input@vger.kernel.org Petr Cvek writes: > This patch adds a support for ADS7846 touchscreen driver. > > The basic functionality was tested, x_plate_ohms and y_plate_ohms were > physically measured. The value pressure_max was empirically set to match > the measured range, which is affected by x_plate_ohms and ADS samples. > > The value of keep_vref_on should be set. A tested model (T-Mobile MDA > Compact PM10A) doesn't seem to use Vref pin as the input from an external > source. On this model the unset keep_vref_on cause high jitter of measured > values. > > SPI framing pin (gpio_cs) must be used in GPIO mode due to an incompatible > autoframing of PXA27x controller and ADS7846 device. > > Signed-off-by: Petr Cvek Applied to pxa/for-next, unless Philipp objects in the next couple of days, thanks. Cheers. -- Robert