linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Markuss Broks <markuss.broks@gmail.com>
To: Karel Balej <karelb@gimli.ms.mff.cuni.cz>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Henrik Rydberg <rydberg@bitmath.org>,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: "Duje Mihanović" <duje.mihanovic@skole.hr>,
	~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org, "Karel Balej" <balejk@matfyz.cz>
Subject: Re: [PATCH v3 5/5] input/touchscreen: imagis: add support for IST3032C
Date: Mon, 4 Dec 2023 14:45:08 +0200	[thread overview]
Message-ID: <89f7e7de-c574-49ab-885d-c6d4427fe64f@gmail.com> (raw)
In-Reply-To: <20231202125948.10345-6-karelb@gimli.ms.mff.cuni.cz>

Hi Karel,

On 12/2/23 14:48, Karel Balej wrote:
> From: Karel Balej <balejk@matfyz.cz>
>
> IST3032C is a touchscreen chip used for instance in the
> samsung,coreprimevelte smartphone, with which this was tested. Add the
> chip specific information to the driver.
>
> Signed-off-by: Karel Balej <balejk@matfyz.cz>
> ---
>   drivers/input/touchscreen/imagis.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/drivers/input/touchscreen/imagis.c b/drivers/input/touchscreen/imagis.c
> index 84a02672ac47..41f28e6e9cb1 100644
> --- a/drivers/input/touchscreen/imagis.c
> +++ b/drivers/input/touchscreen/imagis.c
> @@ -35,6 +35,8 @@
>   #define IST3038B_REG_CHIPID		0x30
>   #define IST3038B_WHOAMI			0x30380b
>   
> +#define IST3032C_WHOAMI			0x32c
> +
Perhaps it should be ordered in alphabetic/alphanumeric order, 
alternatively, the chip ID values could be grouped.
>   struct imagis_properties {
>   	unsigned int interrupt_msg_cmd;
>   	unsigned int touch_coord_cmd;
> @@ -363,6 +365,13 @@ static int imagis_resume(struct device *dev)
>   
>   static DEFINE_SIMPLE_DEV_PM_OPS(imagis_pm_ops, imagis_suspend, imagis_resume);
>   
> +static const struct imagis_properties imagis_3032c_data = {
> +	.interrupt_msg_cmd = IST3038C_REG_INTR_MESSAGE,
> +	.touch_coord_cmd = IST3038C_REG_TOUCH_COORD,
> +	.whoami_cmd = IST3038C_REG_CHIPID,
> +	.whoami_val = IST3032C_WHOAMI,
> +};
> +
>   static const struct imagis_properties imagis_3038b_data = {
>   	.interrupt_msg_cmd = IST3038B_REG_STATUS,
>   	.touch_coord_cmd = IST3038B_REG_STATUS,
> @@ -380,6 +389,7 @@ static const struct imagis_properties imagis_3038c_data = {
>   
>   #ifdef CONFIG_OF
>   static const struct of_device_id imagis_of_match[] = {
> +	{ .compatible = "imagis,ist3032c", .data = &imagis_3032c_data },
>   	{ .compatible = "imagis,ist3038b", .data = &imagis_3038b_data },
>   	{ .compatible = "imagis,ist3038c", .data = &imagis_3038c_data },
>   	{ },

Other than that,

Reviewed-by: Markuss Broks <markuss.broks@gmail.com>

- Markuss


  reply	other threads:[~2023-12-04 12:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-02 12:48 [PATCH v3 0/5] input/touchscreen: imagis: add support for IST3032C Karel Balej
2023-12-02 12:48 ` [PATCH v3 1/5] input/touchscreen: imagis: Correct the maximum touch area value Karel Balej
2023-12-02 12:48 ` [PATCH v3 2/5] dt-bindings: input/touchscreen: Add compatible for IST3038B Karel Balej
2023-12-03 11:20   ` Conor Dooley
2023-12-04 12:40     ` Markuss Broks
2023-12-04 12:52       ` Conor Dooley
2023-12-09  9:05         ` Karel Balej
2023-12-09 10:58           ` Conor Dooley
2023-12-27 11:55             ` Karel Balej
2023-12-02 12:48 ` [PATCH v3 3/5] input/touchscreen: imagis: Add support for Imagis IST3038B Karel Balej
2023-12-05 10:21   ` kernel test robot
2023-12-02 12:48 ` [PATCH v3 4/5] dt-bindings: input/touchscreen: imagis: add compatible for IST3032C Karel Balej
2023-12-03 11:19   ` Conor Dooley
2023-12-02 12:48 ` [PATCH v3 5/5] input/touchscreen: imagis: add support " Karel Balej
2023-12-04 12:45   ` Markuss Broks [this message]
2023-12-08 21:59     ` Karel Balej
2023-12-09 20:50       ` Markuss Broks
2023-12-05 14:49   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89f7e7de-c574-49ab-885d-c6d4427fe64f@gmail.com \
    --to=markuss.broks@gmail.com \
    --cc=balejk@matfyz.cz \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=duje.mihanovic@skole.hr \
    --cc=karelb@gimli.ms.mff.cuni.cz \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rydberg@bitmath.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).