From: Basavaraj Natikar <bnatikar@amd.com>
To: Jiri Kosina <jikos@kernel.org>, Helge Bahmann <hcb@chaoticmind.net>
Cc: Nehal Bakulchandra Shah <Nehal-Bakulchandra.Shah@amd.com>,
Sandeep Singh <Sandeep.singh@amd.com>,
Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
bentiss@kernel.org, linux-hid@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH] amd-sfh-hid: tablet mode switch and asus quirk
Date: Tue, 12 May 2026 22:39:26 +0530 [thread overview]
Message-ID: <8a07b89d-564a-435e-9d71-1d7f884d1cf4@amd.com> (raw)
In-Reply-To: <n0s5q66s-p747-612p-o743-pqr0q2r79448@xreary.bet>
On 5/12/2026 9:36 PM, Jiri Kosina wrote:
> On Mon, 27 Apr 2026, Helge Bahmann wrote:
>
>> Add an input driver that interprets the "operation mode" sensor offered
>> by the amd sfh on some laptop models.
>>
>> Add a quirk to make the driver work again with the Asus VivoBook
>> VivoBook (turn off the "disable interrupts" flag).
>>
>> Expose the intr_disable flag as a module parameter in case it turns out
>> to be needed on further laptop models.
>>
>> Signed-off-by: Helge Bahmann <hcb@chaoticmind.net>
> Basavaraj, can you please review this one?
Hi Jiri,
Sure, will review. The patch has some changes that deviate from how
other sensors are exposed in this driver, so it will take some time to
review properly. I'll respond with detailed feedback once done.
Thanks,
--
Basavaraj
next prev parent reply other threads:[~2026-05-12 17:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 6:22 [PATCH] amd-sfh-hid: tablet mode switch and asus quirk Helge Bahmann
2026-05-12 16:06 ` Jiri Kosina
2026-05-12 17:09 ` Basavaraj Natikar [this message]
2026-05-14 7:59 ` Helge Bahmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a07b89d-564a-435e-9d71-1d7f884d1cf4@amd.com \
--to=bnatikar@amd.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=Nehal-Bakulchandra.Shah@amd.com \
--cc=Sandeep.singh@amd.com \
--cc=bentiss@kernel.org \
--cc=hcb@chaoticmind.net \
--cc=jikos@kernel.org \
--cc=linux-hid@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox