From: "Nguyen, Max" <hphyperxdev@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: xpad - Add additional HyperX Controller Identifiers
Date: Mon, 4 Mar 2024 16:43:10 -0800 [thread overview]
Message-ID: <8a2e32ad-abbe-4459-ac99-c0b8e8e2cdef@gmail.com> (raw)
In-Reply-To: <ZeT9cbHRVe7td8WB@google.com>
On 3/3/2024 2:45 PM, Dmitry Torokhov wrote:
> Hi Max,
>
> On Fri, Mar 01, 2024 at 06:15:42PM -0800, Nguyen, Max wrote:
>> Add additional HyperX device identifiers to xpad_device and xpad_table. Cc:
>> stable@vger.kernel.org Suggested-by: Chris Toledanes<chris.toledanes@hp.com>
>> Reviewed-by: Carl Ng<carl.ng@hp.com>
>> Signed-off-by: Max Nguyen<maxwell.nguyen@hp.com>
> Your client messes up patches :(
Sorry about that... I tried to submit through a different client. I will submit through my previous method next time.
>
>> ---
>>
>> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
>> index 7c4b2a5cc1b5..a7e001a1f6dc 100644
>> --- a/drivers/input/joystick/xpad.c
>> +++ b/drivers/input/joystick/xpad.c
>> @@ -131,6 +131,11 @@ static const struct xpad_device {
>> { 0x03eb, 0xff01, "Wooting One (Legacy)", 0, XTYPE_XBOX360 },
>> { 0x03eb, 0xff02, "Wooting Two (Legacy)", 0, XTYPE_XBOX360 },
>> { 0x03f0, 0x0495, "HyperX Clutch Gladiate", 0, XTYPE_XBOXONE },
>> + { 0x03f0, 0x08B6, "HyperX Clutch Gladiate", 0, XTYPE_XBOXONE }, /* v2 */
>> + { 0x03f0, 0x07A0, "HyperX Clutch Gladiate RGB", 0, XTYPE_XBOXONE },
>> + { 0x03f0, 0x038D, "HyperX Clutch", 0, XTYPE_XBOX360 }, /* wired */
>> + { 0x03f0, 0x048D, "HyperX Clutch", 0, XTYPE_XBOX360 }, /* wireless */
>> + { 0x03f0, 0x09B4, "HyperX Clutch Tanto", 0, XTYPE_XBOXONE },
> These need to be sorted by VID/PID.
>
> I fixed it up and applied.
>
> Thanks.
Can you help explain the sort? Do the VID/PIDs need to be in sequential order?
next prev parent reply other threads:[~2024-03-05 0:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 2:15 [PATCH] Input: xpad - Add additional HyperX Controller Identifiers Nguyen, Max
2024-03-03 22:45 ` Dmitry Torokhov
2024-03-05 0:43 ` Nguyen, Max [this message]
2024-03-05 1:04 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a2e32ad-abbe-4459-ac99-c0b8e8e2cdef@gmail.com \
--to=hphyperxdev@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox