From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2049.outbound.protection.outlook.com [40.107.237.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAC491A0BC4; Tue, 3 Sep 2024 09:41:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.49 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725356491; cv=fail; b=kvTge7mWEf/Pcw31PZSslEx519josr+V/ZxKZ0n6o0RMA1xNMmDQoMvv7nUAPLMm7drVrfrTL3yVN2I8H2JjHcufx4GhALe8WXW4WHCN2nJjRi+gOhxGN5GH2nd+RQypZTgxxU2UY5oWqZPY3m5oNCqtSyIqr5vC0U2MLS5PlIo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725356491; c=relaxed/simple; bh=KyH/yUQBRZZp6RsrWFtlzL0I1p+WCyz0iJv4+p1dtu4=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=tNLFbtCDZO5uUYmkjnByf17kwkbZL9AV0O8Vlm/6yWL74iXHzdkvxDmYeoa2xLu6+BjMvctKsHU16jLpRZahh++AaH/C5f6mBmAUFov2FV4i1+/0giI9KnuwV4iEsHJQ6BnrFVltyAXzZlNIBDaFhTwgMCDXc9BAnMDKBuhR5zg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=KkHz+mWA; arc=fail smtp.client-ip=40.107.237.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="KkHz+mWA" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rn/cLzLZ4n6sS18I4/OYKG4RRn5iNp6jtLmaGImTJJmVJRyQfjxf0mGsP7RjkMPzknDt2LqoT2qlYqDb4+ZkMyMMVY0s+jwq0t9S//atu1SgEfo2Da+XqSU8f8G1EqAu5cvylIx1AMsidpcDVBmd6eWZt4E4gmYsTpSoHlEisEpMHPzGazZ01gNboLC6BCBH60yJswQPlZTJNGjsYLfUQgjBWcGMFxgsmK6+2YIe9s2kLGU0qYw16IxN/dsSk3XGUR2TBmPtnLOQmn7QDxcENeVO1ornViaKSHH/IB5ljJ+P+VOBqYnK7wUHxoVb7a1I/eEtWt5rJ+lPXjusoUmzqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dO4LKL4F52P96PggFe/AlAu3y6vbIIj7Udx7/HsL6bA=; b=G4ub7lDV32IYy3QpjLpBm4OoPb9ERaHf4eg/IacNHVBaBMNTD3V2ZI2//Rb4/uFZo9hNFCq2JqorPUgB/j6nSIQk2pXtaBtwzMUy4ZvQ7WZfIZlYmMO532mV9wgPMImrgYQLwhm921i1KLdeUJAEQzuNyafcfhE/OIbWWF4yGPrqFkwuFA1ASHNGCOKpMgTKVU2PuEYdj2yu7lJun84AEFCRPFrih+stK7Fb87c8s4k/1SceHaxAKJOU1QC4rhAkYvsYNgHCHBgdlzn6kFQRgEFqXXPyZUeso5wq3Y1mRpqPAmxZzq+6O0QFhYi+Wazza2J2bfLv+FPYC1uyS1qz3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dO4LKL4F52P96PggFe/AlAu3y6vbIIj7Udx7/HsL6bA=; b=KkHz+mWAiPti8yGtPvaGYEw5woMd8HCOfOiIVTj2C//UEhmvixiqkYw6YEWS8eyln/ejvflnFmb30jTzgZstFAEdU+30KBfJ4Dh6kdhfIHGJezDCa8SQsUc3V/QzlOwmp/5QE03B/dP6b5U/GPdw27jUEHhEr6xClpA4p14TtZo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from BN9PR12MB5033.namprd12.prod.outlook.com (2603:10b6:408:132::14) by SJ2PR12MB7964.namprd12.prod.outlook.com (2603:10b6:a03:4cf::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.23; Tue, 3 Sep 2024 09:41:26 +0000 Received: from BN9PR12MB5033.namprd12.prod.outlook.com ([fe80::deef:fa00:d7d4:5069]) by BN9PR12MB5033.namprd12.prod.outlook.com ([fe80::deef:fa00:d7d4:5069%7]) with mapi id 15.20.7918.024; Tue, 3 Sep 2024 09:41:25 +0000 Message-ID: <8b87ecff-4ef9-4749-b85a-43e343d08c9a@amd.com> Date: Tue, 3 Sep 2024 15:11:15 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] HID: amd_sfh: Convert comma to semicolon To: Chen Ni , basavaraj.natikar@amd.com, jikos@kernel.org, bentiss@kernel.org, Shyam-sundar.S-k@amd.com, mario.limonciello@amd.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240903024402.493709-1-nichen@iscas.ac.cn> Content-Language: en-US From: Basavaraj Natikar In-Reply-To: <20240903024402.493709-1-nichen@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN3PR01CA0031.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:97::20) To BN9PR12MB5033.namprd12.prod.outlook.com (2603:10b6:408:132::14) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN9PR12MB5033:EE_|SJ2PR12MB7964:EE_ X-MS-Office365-Filtering-Correlation-Id: 39653713-3c1e-450c-c3e0-08dccbfc923f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VWF2cXVtTjJRN0hRNzdjTDJNMHRvUmRQbUVJcHA3NGpWRXNSOFUwaXJLRS9v?= =?utf-8?B?SnBUR1BZd0k5NTVtS29oYnBGRThTdUw0S2Q1NnUwL2dvOTUzQXp2RlF3VUJz?= =?utf-8?B?MjF3VCtsZjF6T3NGKy8wbUFJY1pWZjlpazJlY0xYQnlKaEkxalhTaGtYLzBZ?= =?utf-8?B?WE1hOWR0QzU3dW81QmpocWprTlFuSGpOK3FKVFJLQmNNU0dTenRoenZGWUtL?= =?utf-8?B?ZzVPL1NuNUpRYy8vSUtHOHVCMGJvQlI4SDkwY0lnMWxaU3dJOXFSYzdGN1RD?= =?utf-8?B?S1A2dFpONmk1bnRsWkt4Y1FraDRQbytFYk5LbmlieTFObTVENmFXTlJZRkFH?= =?utf-8?B?aWVZYk52WlpaZ082T3JXbTFxYlVsM2U0Q2ZpRDdDcjl1VGJhVVBYeGdiT0Qy?= =?utf-8?B?RmJpSlg5elZIWHRGV0M1N1NVMG8xT1FGWk10a2VaR3lzZ2I0eHFsQXM5azVU?= =?utf-8?B?TklmVGgwNHBNVHlLenJ3c0VsbDcvYmpyM3MyWDRRN05ZOVUvWHdLenRQMUtV?= =?utf-8?B?azBJQUNieThjVHFUTGNoUisxeGxDMHJ2dEdZU0YrZnAxWjBZYjBrRlI2eDds?= =?utf-8?B?dXdHSXRKN0ViaW1QZ1F3Vy8wRzA5QzZRbWxDZ0lxVHBabzhuaUd2VlhTd3hv?= =?utf-8?B?UC8wVXRLRko0aWJyaWN6ZFU4MTdOOVJmV0RmTExnR0phalgzUGUwanNzWjhB?= =?utf-8?B?RlFIQm5taVU3NWJtQ3dxZTZGTG9JSFQ0SlE3MVFCMTFxZ0tKNVFlSTduRHNz?= =?utf-8?B?bExpTURoSnY0aFhQMCtqZlQvQTdHL1hjazBtbWNxRllQRVdKYlg0QTltVHlM?= =?utf-8?B?ekVSdERkejJzam5Jaks2TXRNODJMUFBETVZTK0JxT2ExYzdSa1VGR3daT3lB?= =?utf-8?B?UU5qSHRuZS9heHpiSWt2NnVtdTVHcVVPSkYwR2Y3THhRTGtqKytBQnBwMk5F?= =?utf-8?B?NSttZ2hxNTFjTnBnM0MrQjYrL1haQlRSTnlFangzdzQ5VDVyQWpjZkRZdHB0?= =?utf-8?B?eUhsNUR2d2VlNEVLMTM0MTFGMGlNc3krUjM4MW9oUlkya3dSdnBwcGFNbWVs?= =?utf-8?B?QklrV0J4SUlGRGNybmJCYWV6N2doNGcvbU9CYlBjbjlIZVJSckVZT2tkM21u?= =?utf-8?B?dmI2a3dnNTkwNmlXcENDWVBCcHBKOGJuY3k4clNuME9TcXA5WkZIK0cyUTBT?= =?utf-8?B?RTVlNG5OM0RXMjZjM1FjTUV1c21qY2VzUmJ6R0VDV01EVGsvc1V5Z0NTWkp1?= =?utf-8?B?YnFwM1QwazB6U2J4cmRUNVZ2WGdYOWwvSjJ0dnVSWHh1d2dpeElWeHhPQ3Jk?= =?utf-8?B?RUp5Y043WndZbDlVZWFUc3pydVVJZ2Nmd1FuSGF5eitRbTU4YW9ua1JiUWdh?= =?utf-8?B?K0FQZGc0dnE4NUdKU3BTb0k5eWp1Sm5TWEhuVW5mWlNDNndNQ2JJSU13NVV5?= =?utf-8?B?ZFhhU2JJMVZEQkRKd3ZaSEUvdW9xTVhvV3VhN3V2bFRHM3M5K3gvbE92MFdS?= =?utf-8?B?ekkxWGRmemdYL0IyeUtIdUEwWnlTSVhsRFo2ZjJLcU95eHBUdWpuc2Erc05n?= =?utf-8?B?TWpVTFVReFBVdVltWTNGb1I0MVpQZU51Z05VckdVM3AwcjdNZXNTYUZDRCti?= =?utf-8?B?MUFvWnltaVg0TmovbzhWRFVNUWFzeTh0STBiRStrZDYzaVd6RG5paFYvOGFz?= =?utf-8?B?RGdmNEhjMjRRL05jaGgyN0NKa0NhQ05yeCtnSUJMRE9hd3lVMC9zT05DdmNV?= =?utf-8?B?NkFpTkJSc1Q2aEx2eGNWa2VFbWE0NGFHaEFnbWM0cUYxTzk3VWtZV0FiUEZQ?= =?utf-8?B?NXE1UWo0dVJ3a014UlZPUT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR12MB5033.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHZxeG9kZE5RNlJNb3J2VDVsZnJYbVlNMkRpYW1jRmFVbHN0OERUSnBPMmNZ?= =?utf-8?B?ZWs4KzZnYTVtSEVubUVVQVJvR2NUSHM5RUZ6aGxtdzY1azdSSXg5Q21UcFJQ?= =?utf-8?B?U2FjNmhtNkNqbmd2TSt1b2JJclM3ZnU3RkdMQWJiZHBSS3RpQjF4eWNUQVFK?= =?utf-8?B?bWN2U0NqU25HWFBBRExNZDFSMTlDL3pxZSt5dnM5M3NWRlA0b1g2eTJ2S1BF?= =?utf-8?B?Sk5OeVVqY25uK0NrTjF6RkNzL2xZMDgzVUV5VG54ck9neHgxSVpTMWlMWW5w?= =?utf-8?B?eUIrQy9raW1vcFQ4alRCdEduaDBMMDBDL2c1QndTM0NkeENaYWZMUmZ6OXdi?= =?utf-8?B?NXFYck1PMFp2cDEraWdabjBycE1QM1JpbG43dkFsQTc3K2ZOR2I1N0VZcmR6?= =?utf-8?B?dzd3VHlMVnFGc0o4R2lzU2VZeFhqUW9PZkk5OFNwY00yWC94K0hLdHhGU2ty?= =?utf-8?B?QkFpT0xKc3NVcGVycTZDMzIrTTMrM3JhczhHS2dSVE5aL296ek1IOEZCVWhH?= =?utf-8?B?QjlML0UxREpUMEtnVW10T0RoRzBkQkpoK3VsUGlJN01mSkZLWGRYZWV2bjEy?= =?utf-8?B?VGhWYTFEcFZRamZXbkZaa2tUU3ZVZWpEUlFPU1BEVWlkTmxPQlNScW9rdEE1?= =?utf-8?B?WVJMMXF3Ti9SNm1qUWNLRzR0cmZSZUIraXdZTnJuRWRheUlsdjFpbGlHM0VS?= =?utf-8?B?UkhpamZMMVNNVE5zSDdVOGFkUTNoZldQeTRzZ1lid05DMFpWUmFGQjZ2VEcv?= =?utf-8?B?dSswbTRBemFWOFVpbmNFNitnVFJnbVJLc0w1V1NyMG1NWlZQM251ZWlRT0I1?= =?utf-8?B?MGU3QlJrSjZoWk81TzdzWDJ6bVBMeFgwcUhuNHloS1dJUytjZ2JLY1lpRkpt?= =?utf-8?B?SFJsTEZlWkU4SzRiRXZ1WTNhWmxsTGFpV2M0Y2IzVXJBcExKY0dka1orL1F5?= =?utf-8?B?c0F3SXV5Rk1jcC8raitCOEFHNzRkd0J5UmNpVyttQlFaazAySUFvaFJqS0ho?= =?utf-8?B?SktSRTR1U1Z5aDFhS0M3ZlpSMHpUTEpJMk8wZVNURDIrVGsvazEvSVdYTG5h?= =?utf-8?B?eEVvNXhHWHlucEJXc05hYjZMNnZqYkJDNGFGUUo4MUVaRWJtbWtDNWNHUlE4?= =?utf-8?B?OHQ1N25BMThMUG15VCt5ejI5dUJkQVpkb3lGdXRRY095ZWxnWm1vUDkwN25O?= =?utf-8?B?RTZOc0pmUmpRbW5jbXhQOC9BUk5vZkUvVkVhbERHWE5NQVNIQVBsY1YwdlN0?= =?utf-8?B?LzNaazQ2eisyTlJKb1dOTXVGQ2ZUUXh5RFQ1MnFQYlNxaXpsb3pLcmRaRGhP?= =?utf-8?B?anRyMW1KeDJBbjNsMHRkMkxSTmFqWmRWUnU3Qit0c1Ntbit6MUdjbjVpbFd6?= =?utf-8?B?OXJRWW5TaFdjdUtNQ3QzVlhOaWpmL1NLL1haOGFPUVFmaDFoUFJhMTNUbVJO?= =?utf-8?B?WjVubUQ4anVOS1lTOFZ4cDlkaWdSbXgyS3BPdnUvNkkzQ08xdEhEOElmZjhi?= =?utf-8?B?TkUvZ0hUSDVTZGQ0eVZtK2hpZU5oeHJ0cjFlVnhUSkVvQVl5Y2d6YkxXb1Jm?= =?utf-8?B?bElvSVZOZG9qWVBnYUpwSGRLWlIzdm1jaHloMXRGN1l0bkdBY3ZvMkYxRXpj?= =?utf-8?B?c3JWa0UvL3hWcGNueHNoWnUyaWc3UmFyeHhIQ3UrYVA4TTJnc3ZpN2diTWUr?= =?utf-8?B?am9ROXR0OHczTFFZYm5mMzEvbTgyOTYvWGdrMEtZdTJ3R21EUTV4bXh2Mnhh?= =?utf-8?B?L1FDaUFvbWdwN09LR2xEcGhtSm1OZGtPOWFGdGw4SWszYmNYcTdVRXFTQVVC?= =?utf-8?B?NnNraEt2NWI4d3hlaFF2cnFkYkkwd3lXM3k2Tzg2R3VJbWFRazlXSEtlMFhS?= =?utf-8?B?YkZ0d2hnUkdlOEYySis4b2pSbXMrMGFEZklqeWIvUVByVnZmTmhWRVlNaEpp?= =?utf-8?B?U1piNCtKRTlKL1hYZHFoM1gycTdIdVdQYkZrKzhqZGlVT0FBK29JSDVTSk1H?= =?utf-8?B?MFB0cWd4ZHpBMW91UUNjWjVzZXJtci92YWNSVG9CTnRzM3BxVFptNXlXU0Vk?= =?utf-8?B?SXM5STNaRjIyMWdHQkUzT1VyWklaU3R6aDUydmxzOFZQcVAyVWo0L0gyT2lJ?= =?utf-8?Q?Oof/W6/T4+H/P+JNXsbo/EfOG?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39653713-3c1e-450c-c3e0-08dccbfc923f X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5033.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2024 09:41:25.7729 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZPj+bfHT977I/g+rNfHYjzc78PI8maeaAuNCHlnwLr1PyQi9nzfrX/+4OmGgm+KivC7U/SY7Ldnp5m7DIrCIGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7964 On 9/3/2024 8:14 AM, Chen Ni wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Chen Ni > --- > drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c > index 621793d92464..db36d87d5634 100644 > --- a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c > +++ b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c > @@ -299,8 +299,8 @@ static void amd_sfh_set_ops(struct amd_mp2_dev *mp2) > > sfh_interface_init(mp2); > mp2_ops = mp2->mp2_ops; > - mp2_ops->clear_intr = amd_sfh_clear_intr_v2, > - mp2_ops->init_intr = amd_sfh_irq_init_v2, > + mp2_ops->clear_intr = amd_sfh_clear_intr_v2; > + mp2_ops->init_intr = amd_sfh_irq_init_v2; > mp2_ops->suspend = amd_sfh_suspend; > mp2_ops->resume = amd_sfh_resume; > mp2_ops->remove = amd_mp2_pci_remove; Looks good to me. Acked-by: Basavaraj Natikar Thanks, -- Basavaraj