From: Alexandru Serdeliuc <serdeliuk@yahoo.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <bentiss@kernel.org>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: asus: add new Asus EC hid device for keyboard backlight and FN HotKeys
Date: Wed, 22 Jul 2026 08:25:09 +0200 [thread overview]
Message-ID: <8bb2a72b-a1cd-4504-b96b-63f8b447417e@yahoo.com> (raw)
In-Reply-To: <5o7r0493-19r1-208p-404q-n0nq453170q6@xreary.bet>
Hi Jiri,
Thanks for the feedback! No problem at all, December is always a busy
time of year, and there was no rush on this anyway.
I am going to test integrating the logic into hid-asus locally first on
the Zenbook A14 to confirm everything builds and functions properly on
this platform (aarch64).
Once I verify that it works as expected, I will report back and send
over a v2 patch series.
Thanks,
Alexandru
On 7/1/26 16:12, Jiri Kosina wrote:
> On Tue, 30 Jun 2026, Alexandru Serdeliuc wrote:
>
>> Hi Jiri, Benjamin,
>>
>> Enquiring if anyone has had a chance to look over this patch series from
>> December?
>>
>> To provide a bit of architectural context, this is a 100% pure HID client
>> driver.
>>
>> This laptop (Asus Zenbook A14 UX3407QA) runs on the Qualcomm ARM64 Snapdragon
>> platform.
>>
>> Because it is an ARM device, it does not use traditional legacy x86 ACPI/WMI
>> code.
>>
>> Instead, the Fn hotkeys and keyboard backlight controls are routed completely
>> through standard vendor-specific HID reports (using Report ID 0x5A) over the
>> existing I2C-HID transport layer.
>>
>> It requires absolutely zero Device Tree modifications or external platform
>> subsystem hooks to bind or function.
>>
>> The driver matches strictly on Vendor/Product ID (0x0B05 / 0x0220) passed
>> directly through the core HID subsystem.
>>
>> I would highly appreciate any architectural feedback or a quick review!
>
> Hi Alexandru,
>
> first - sorry for not having handled this, it somehow fell in between
> cracks.
>
> I have just one question -- wouldn't it be better to have this device
> handled as part of generic hid-asus driver? Giving too many Kconfig
> configurations for every specific model feels a little bit too
> overwhelming.
>
> (yes, we'd need to have hid-asus depend on I2C ... I don't think that's a
> big issue).
>
> Thanks, and sorry again,
>
prev parent reply other threads:[~2026-07-22 6:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-21 11:12 [PATCH] HID: asus: add new Asus EC hid device for keyboard backlight and FN HotKeys Alexandru Marc Serdeliuc via B4 Relay
2026-06-30 16:43 ` Alexandru Serdeliuc
2026-07-01 14:12 ` Jiri Kosina
2026-07-22 6:25 ` Alexandru Serdeliuc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bb2a72b-a1cd-4504-b96b-63f8b447417e@yahoo.com \
--to=serdeliuk@yahoo.com \
--cc=bentiss@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox