From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Subject: Re: [Uclinux-dist-devel] [PATCH 2/2] input/joystick: new Blackfin rotary input driver Date: Thu, 23 Jul 2009 03:46:18 -0400 Message-ID: <8bd0f97a0907230046t108e9ff1y747caf16aadc6de4@mail.gmail.com> References: <1247592827-16878-1-git-send-email-vapier@gentoo.org> <1247592827-16878-2-git-send-email-vapier@gentoo.org> <20090723044338.GB2782@dtor-d630.eng.vmware.com> <8bd0f97a0907222346x7e80799fkf88c7b59c61091b7@mail.gmail.com> <20090723072550.GA3997@dtor-d630.eng.vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-gx0-f213.google.com ([209.85.217.213]:64235 "EHLO mail-gx0-f213.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753614AbZGWHqi convert rfc822-to-8bit (ORCPT ); Thu, 23 Jul 2009 03:46:38 -0400 Received: by gxk9 with SMTP id 9so1402582gxk.13 for ; Thu, 23 Jul 2009 00:46:38 -0700 (PDT) In-Reply-To: <20090723072550.GA3997@dtor-d630.eng.vmware.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: uclinux-dist-devel@blackfin.uclinux.org, Michael Hennerich , linux-input@vger.kernel.org On Thu, Jul 23, 2009 at 03:25, Dmitry Torokhov wrote: > On Thu, Jul 23, 2009 at 02:46:11AM -0400, Mike Frysinger wrote: >> On Thu, Jul 23, 2009 at 00:43, Dmitry Torokhov wrote: >> > On Tue, Jul 14, 2009 at 01:33:47PM -0400, Mike Frysinger wrote: >> >> +struct platform_driver bfin_rotary_device_driver =3D { >> >> + =C2=A0 =C2=A0 .probe =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D bfin= _rotary_probe, >> >> + =C2=A0 =C2=A0 .remove =C2=A0 =C2=A0 =C2=A0 =C2=A0 =3D __devexit= _p(bfin_rotary_remove), >> >> + =C2=A0 =C2=A0 .suspend =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D bfin_rota= ry_suspend, >> >> + =C2=A0 =C2=A0 .resume =C2=A0 =C2=A0 =C2=A0 =C2=A0 =3D bfin_rota= ry_resume, >> > >> > Need to use dev_pm_ops so platform code won;t yell at us. >> >> looks like something new post 2.6.30 ... guess i'll have to keep thi= s >> in mind for migrating drivers when 2.6.31 comes out >> >> > I also think that this driver should too live in drivers/input/mis= c so I >> > moved it there. I did a bit of reshuffling in the patch, could you >> > please give it a try and if it still works I'll apply to the 'next= ' >> > branch. >> >> could you toss like a standard dev_info("initialized") into the end = of >> bfin_rotary_probe ? =C2=A0otherwise, builds and works fine for me wi= th >> 2.6.31-rc4. =C2=A0thanks! > > Don't you find the boot to be too noisy? The input core already > prints a message when a new input device is registered... you're right. when i was testing, i didnt update my board resources and so was seeing no output, so i added the dev_info() while also fixing the resources. didnt notice the additional input core output. current behavior is fine then, thanks! -mike -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html