From: Mike Frysinger <vapier.adi@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Javier Herrero <jherrero@hvsistemas.es>,
Bryan Wu <cooloney@kernel.org>
Subject: Re: [PATCH v4] input/keyboard: new OpenCores Keyboard Controller driver
Date: Tue, 15 Sep 2009 23:57:32 -0400 [thread overview]
Message-ID: <8bd0f97a0909152057v2049371aif4118691d56165c8@mail.gmail.com> (raw)
In-Reply-To: <20090916034555.GA2756@core.coreip.homeip.net>
On Tue, Sep 15, 2009 at 23:45, Dmitry Torokhov wrote:
> On Tue, Sep 15, 2009 at 10:00:40PM -0400, Mike Frysinger wrote:
>> +
>> +static int __devexit opencores_kbd_remove(struct platform_device *pdev)
>> +{
>> + struct opencores_kbd *opencores_kbd = platform_get_drvdata(pdev);
>> +
>> + free_irq(opencores_kbd->irq, opencores_kbd);
>> +
>> + input_unregister_device(opencores_kbd->input);
>> + kfree(opencores_kbd);
>
> You need to do iounmap and free the memory region here as well.
ugh, i remembered i would have to do this while writing the initial
code, but forgot while double checking the different error paths
-mike
next prev parent reply other threads:[~2009-09-16 3:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 2:17 [PATCH] input/keyboard: new OpenCores Keyboard Controller driver Mike Frysinger
2009-09-14 6:17 ` Andrey Panin
2009-09-14 7:04 ` [PATCH v2] " Mike Frysinger
2009-09-14 7:25 ` Joe Perches
2009-09-14 17:40 ` [PATCH v3] " Mike Frysinger
2009-09-14 17:49 ` Dmitry Torokhov
2009-09-14 18:02 ` Mike Frysinger
2009-09-14 18:18 ` Javier Herrero
2009-09-15 5:52 ` Dmitry Torokhov
2009-09-15 11:16 ` Mike Frysinger
2009-09-15 16:23 ` Dmitry Torokhov
2009-09-15 16:39 ` Mike Frysinger
2009-09-16 2:00 ` [PATCH v4] " Mike Frysinger
2009-09-16 3:45 ` Dmitry Torokhov
2009-09-16 3:57 ` Mike Frysinger [this message]
2009-09-16 4:10 ` [PATCH v5] " Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0909152057v2049371aif4118691d56165c8@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=cooloney@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jherrero@hvsistemas.es \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).