From: Mike Frysinger <vapier.adi@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: "Hennerich, Michael" <Michael.Hennerich@analog.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
Bryan Wu <cooloney@kernel.org>
Subject: Re: [PATCH] input/keyboard: new driver for ADP5520 MFD PMICs
Date: Tue, 22 Sep 2009 10:21:35 -0400 [thread overview]
Message-ID: <8bd0f97a0909220721i4655145ao42f97673e3dc6185@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.0909220954360.17028@wotan.suse.de>
On Tue, Sep 22, 2009 at 03:56, Jiri Kosina wrote:
> On Tue, 22 Sep 2009, Hennerich, Michael wrote:
>
>> >It actually doesn't seem to be the same condition (KP_INT vs. KR_INT),
>> >but it's difficult to say, as these constants are apparently added in
>> >some other patch I have no idea about.
>>
>> KP Key-Press versus Key-Release
>>
>> >And the same for other constants used in the code ... the patch seems to
>> >be quite incomplete.
>>
>> The missing constants are in include/linux/mfd/adp5520.h
>>
>> This file was sent in a different patch, adding support for the Multi Function Device Core
>> (drivers/mfd/adp5520.c)
>
> The dependency on another patch should be either at least expressed in the
> patch Changelog, or even better send the patches as series with proper
> numbering, so that the dependency is obvious.
we've already been over this. read the whole thread and/or search
lkml for the mfd patch. the followup will contain the dependency
info, but until then, the exact define values really arent relevant to
review of this code.
-mike
next prev parent reply other threads:[~2009-09-22 14:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 18:24 [PATCH] input/keyboard: new driver for ADP5520 MFD PMICs Mike Frysinger
[not found] ` <1253211850-29309-1-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2009-09-20 6:30 ` Andrew Morton
2009-09-20 22:40 ` [Uclinux-dist-devel] " Mike Frysinger
2009-09-21 4:04 ` Andrew Morton
[not found] ` <20090920210451.60ad1b1f.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-09-21 13:40 ` Mike Frysinger
2009-09-21 18:23 ` [Uclinux-dist-devel] " Andrew Morton
2009-09-22 5:59 ` Dmitry Torokhov
2009-09-22 7:33 ` Jiri Kosina
2009-09-22 7:53 ` Hennerich, Michael
2009-09-22 7:56 ` Jiri Kosina
2009-09-22 14:21 ` Mike Frysinger [this message]
2009-09-22 15:06 ` Dmitry Torokhov
2009-09-23 5:15 ` [PATCH v2] " Mike Frysinger
2009-09-23 6:28 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0909220721i4655145ao42f97673e3dc6185@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=cooloney@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).